2048365 - Add some safeguards around the Nimbus C++ API

Status: RESOLVED FIXED

(Firefox :: Nimbus Desktop Client, enhancement, P1)

Description

[Beth Rennie [:beth] (she/her) - OOO until Sept 14]

We just had a case where a feature was misconfigured and could not use the C++ feature API because isEarlyStartup was false. This made it all the way to release without getting caught.

Instead, we should have some klaxons go off if you call into the feature API for an unsupported feature, e.g., a MOZ_DIAGNOSTIC_ASSERT.

Comment 1

[Beth Rennie [:beth] (she/her) - OOO until Sept 14]

Attachment: Bug 2048365 - MOZ_DIAGNOSTIC_ASSERT when calling the NimbusFeature API with an unsupported feature r?#nimbus-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9673e46434c6
https://hg.mozilla.org/integration/autoland/rev/1d3b92a08ba4
MOZ_DIAGNOSTIC_ASSERT when calling the NimbusFeature API with an unsupported feature r=nimbus-reviewers,chumphreys

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/728c86bf6156
https://hg.mozilla.org/integration/autoland/rev/5ec15046ffc9
Revert "Bug 2048365 - MOZ_DIAGNOSTIC_ASSERT when calling the NimbusFeature API with an unsupported feature r=nimbus-reviewers,chumphreys" for causing failures regarding Nimbus , FeatureManifest.yaml

Comment 4

[Norisz Fay [:noriszfay]]

Backed out for causing failures regarding Nimbus , FeatureManifest.yaml

Backout link

Push with failures

Comment 5

[BugBot [:suhaib / :marco]]

There is an r+ patch which didn't land and no activity in this bug for 1 week.
:beth, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3a069da85cf5
https://hg.mozilla.org/integration/autoland/rev/5c1b97d43142
MOZ_DIAGNOSTIC_ASSERT when calling the NimbusFeature API with an unsupported feature r=nimbus-reviewers,chumphreys

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e4ee0947236a
https://hg.mozilla.org/integration/autoland/rev/293aca64634c
Revert "Bug 2048365 - MOZ_DIAGNOSTIC_ASSERT when calling the NimbusFeature API with an unsupported feature r=nimbus-reviewers,chumphreys" for causing gtest failures related to gtest.NimbusTelemetryFixture

Comment 8

[rperta]

Backed out for causing gtest failures related to gtest.NimbusTelemetryFixture
Backout link
Push with failures
Failure log(s)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/52bfbfecf7f7
https://hg.mozilla.org/integration/autoland/rev/a0b54074afd8
MOZ_DIAGNOSTIC_ASSERT when calling the NimbusFeature API with an unsupported feature r=nimbus-reviewers,chumphreys

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a0b54074afd8