Closed Bug 2048368 Opened 2 months ago Closed 1 month ago

Add about:keyboard entry points to the Settings UI

Categories

(Firefox :: Keyboard Navigation, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
154 Branch
Tracking Status
firefox154 --- fixed

People

(Reporter: ayeddi, Assigned: ayeddi)

References

(Blocks 1 open bug)

Details

(Whiteboard: [customKeysV2])

Attachments

(2 files)

Add entry points for Customizable keyboard shortcuts interface (about:keyboard) to the Settings UI (as confirmed with Brent Trotter earlier this month):

  1. On "Tabs and Browsing" pane as its own group between the existing "Page Navigation" and "Media" groups
  2. On "Accessibility" pane as a link at the end of the "Keyboard navigation and scrolling" group

Add an entry point for Customizable keyboard shortcuts interface (about:keyboard) to the Settings UI (about:preferences):

  1. On "Accessibility" pane (about:preferences#accessibility) as a link at the end of the "Keyboard navigation and scrolling" group

Add an entry point for Customizable keyboard shortcuts interface (about:keyboard) to the Settings UI (about:preferences):

  1. On "Tabs and Browsing" pane (about:preferences#tabsBrowsing) as its own group between the existing "Page Navigation" and "Media" groups

This patch also creates a test file for the "Tabs and Browsing" pane and its categories.

Note: the icon used is a placeholder and needs to be updated once the final icon is created

Attachment #9598563 - Attachment description: WIP: Bug 2048368: Adding entry points for about:keyboard to Settings - Accessibility. r=Jamie!,settings-reviewers-rotation! → WIP: Bug 2048368: Pt.1 - Adding entry points for about:keyboard to Settings - Accessibility. r=Jamie!,settings-reviewers-rotation!
Attachment #9598564 - Attachment description: WIP: Bug 2048368: Adding entry points for about:keyboard to Settings - Tabs. r=Jamie!,settings-reviewers-rotation! → WIP: Bug 2048368: Pt.2 - Adding entry points for about:keyboard to Settings - Tabs. r=Jamie!,settings-reviewers-rotation!
Assignee: nobody → ayeddi
Status: NEW → ASSIGNED
Attachment #9598563 - Attachment description: WIP: Bug 2048368: Pt.1 - Adding entry points for about:keyboard to Settings - Accessibility. r=Jamie!,settings-reviewers-rotation! → Bug 2048368: Pt.1 - Adding entry points for about:keyboard to Settings - Accessibility. r=Jamie!,settings-reviewers-rotation!
Attachment #9598564 - Attachment description: WIP: Bug 2048368: Pt.2 - Adding entry points for about:keyboard to Settings - Tabs. r=Jamie!,settings-reviewers-rotation! → Bug 2048368: Pt.2 - Adding entry points for about:keyboard to Settings - Tabs. r=Jamie!,settings-reviewers-rotation!
Attachment #9598563 - Attachment description: Bug 2048368: Pt.1 - Adding entry points for about:keyboard to Settings - Accessibility. r=Jamie!,settings-reviewers-rotation! → WIP: Bug 2048368: Pt.1 - Adding entry points for about:keyboard to Settings - Accessibility. r=Jamie!,settings-reviewers-rotation!
Attachment #9598564 - Attachment description: Bug 2048368: Pt.2 - Adding entry points for about:keyboard to Settings - Tabs. r=Jamie!,settings-reviewers-rotation! → WIP: Bug 2048368: Pt.2 - Adding entry points for about:keyboard to Settings - Tabs. r=Jamie!,settings-reviewers-rotation!
Attachment #9598563 - Attachment description: WIP: Bug 2048368: Pt.1 - Adding entry points for about:keyboard to Settings - Accessibility. r=Jamie!,settings-reviewers-rotation! → Bug 2048368: Pt.1 - Adding entry points for about:keyboard to Settings - Accessibility. r=Jamie!,settings-reviewers-rotation!
Attachment #9598564 - Attachment description: WIP: Bug 2048368: Pt.2 - Adding entry points for about:keyboard to Settings - Tabs. r=Jamie!,settings-reviewers-rotation! → Bug 2048368: Pt.2 - Adding entry points for about:keyboard to Settings - Tabs. r=Jamie!,settings-reviewers-rotation!
Attachment #9598564 - Attachment description: Bug 2048368: Pt.2 - Adding entry points for about:keyboard to Settings - Tabs. r=Jamie!,settings-reviewers-rotation! → Bug 2048368: Pt.1 - Adding entry points for about:keyboard to Settings - Tabs. r=Jamie!,settings-reviewers-rotation!
Attachment #9598563 - Attachment description: Bug 2048368: Pt.1 - Adding entry points for about:keyboard to Settings - Accessibility. r=Jamie!,settings-reviewers-rotation! → Bug 2048368: Pt.2 - Adding entry points for about:keyboard to Settings - Accessibility. r=Jamie!,settings-reviewers-rotation!
Pushed by ayeddi@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/6e5f5bca6e07 https://hg.mozilla.org/integration/autoland/rev/bfde39fde2ab Pt.1 - Adding entry points for about:keyboard to Settings - Tabs. r=fluent-reviewers,flod,akulyk https://github.com/mozilla-firefox/firefox/commit/89ba2a475298 https://hg.mozilla.org/integration/autoland/rev/887c3e43b898 Pt.2 - Adding entry points for about:keyboard to Settings - Accessibility. r=fluent-reviewers,flod,akulyk
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
QA Whiteboard: [qa-triage-done-c155/b154]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: