Closed Bug 2048386 Opened 5 months ago Closed 4 months ago

Set up boilerplate Privacy widget (prefs/UI) for the New Tab page

Categories

(Firefox :: New Tab Page, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
154 Branch
Tracking Status
firefox154 --- fixed

People

(Reporter: maxx, Assigned: maxx)

References

(Blocks 1 open bug)

Details

Attachments

(1 external file)

Scaffold the Privacy widget using the registry-based New Tab widget convention.

  • Add the privacy entry to WIDGET_REGISTRY in common/WidgetsRegistry.mjs (order, validSizes, defaultSize, telemetryName: "privacy", trainhop keys) and export pref constants (PREF_WIDGETS_PRIVACY_ENABLED, PREF_PRIVACY_SIZE, PREF_WIDGETS_SYSTEM_PRIVACY_ENABLED).
  • Register the three widgets.privacy.* prefs in lib/ActivityStream.sys.mjs (size pref value "").
  • Add Widgets/Privacy/Privacy.jsx + _Privacy.scss and register in WIDGET_ROW_COMPONENTS (Widgets/WidgetsComponentRegistry.jsx). Port rendering from D291586 to the Nova spec (332x276): tracker count, gradient text, insight variants (guard / fewer-trackers / fox-fact), mascot variants, empty/private/error states. Use resolveWidgetSize, useSizeSubmenu, <MoveSubmenu>.
  • Add @import in content-src/styles/activity-stream.scss and the SCSS path in stylelint-rollouts.config.js.
  • Customize panel toggle (Base.jsx, CustomizeMenu.jsx, WidgetsManagementPanel.jsx, ContentSection.jsx) and about:preferences#home registration (lib/AboutPreferences.sys.mjs, home-prefs-privacy-header). Gate visibility via isWidgetAddable.

Add the boilerplate (prefs/UI) for the Privacy widget, the New Tab surface of the Felt Privacy Metrics work, using the registry-based widget convention.

Assignee: nobody → mcrawford
Status: NEW → ASSIGNED
Attachment #9598821 - Attachment description: Bug 2048386 - Scaffold the Privacy widget on the New Tab page r?#home-newtab-reviewers → WIP: Bug 2048386 - Scaffold the Privacy widget on the New Tab page r?#home-newtab-reviewers
Attachment #9598821 - Attachment description: WIP: Bug 2048386 - Scaffold the Privacy widget on the New Tab page r?#home-newtab-reviewers → Bug 2048386 - Scaffold the Privacy widget on the New Tab page r?#home-newtab-reviewers
Pushed by npypchenko@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/94b4a5711b24 https://hg.mozilla.org/integration/autoland/rev/04ec59ae6f34 Scaffold the Privacy widget on the New Tab page r=fluent-reviewers,reemhamz,bolsson
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
QA Whiteboard: [qa-triage-done-c155/b154]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: