Closed
Bug 2048386
Opened 5 months ago
Closed 4 months ago
Set up boilerplate Privacy widget (prefs/UI) for the New Tab page
Categories
(Firefox :: New Tab Page, enhancement)
Firefox
New Tab Page
Tracking
()
RESOLVED
FIXED
154 Branch
| Tracking | Status | |
|---|---|---|
| firefox154 | --- | fixed |
People
(Reporter: maxx, Assigned: maxx)
References
(Blocks 1 open bug)
Details
Attachments
(1 external file)
Scaffold the Privacy widget using the registry-based New Tab widget convention.
- Add the
privacyentry toWIDGET_REGISTRYincommon/WidgetsRegistry.mjs(order,validSizes,defaultSize,telemetryName: "privacy", trainhop keys) and export pref constants (PREF_WIDGETS_PRIVACY_ENABLED,PREF_PRIVACY_SIZE,PREF_WIDGETS_SYSTEM_PRIVACY_ENABLED). - Register the three
widgets.privacy.*prefs inlib/ActivityStream.sys.mjs(size pref value""). - Add
Widgets/Privacy/Privacy.jsx+_Privacy.scssand register inWIDGET_ROW_COMPONENTS(Widgets/WidgetsComponentRegistry.jsx). Port rendering from D291586 to the Nova spec (332x276): tracker count, gradient text, insight variants (guard/fewer-trackers/fox-fact), mascot variants, empty/private/error states. UseresolveWidgetSize,useSizeSubmenu,<MoveSubmenu>. - Add
@importincontent-src/styles/activity-stream.scssand the SCSS path instylelint-rollouts.config.js. - Customize panel toggle (
Base.jsx,CustomizeMenu.jsx,WidgetsManagementPanel.jsx,ContentSection.jsx) andabout:preferences#homeregistration (lib/AboutPreferences.sys.mjs,home-prefs-privacy-header). Gate visibility viaisWidgetAddable.
| Assignee | ||
Comment 1•5 months ago
|
||
Add the boilerplate (prefs/UI) for the Privacy widget, the New Tab surface of the Felt Privacy Metrics work, using the registry-based widget convention.
Updated•5 months ago
|
Assignee: nobody → mcrawford
Status: NEW → ASSIGNED
Updated•5 months ago
|
Attachment #9598821 -
Attachment description: Bug 2048386 - Scaffold the Privacy widget on the New Tab page r?#home-newtab-reviewers → WIP: Bug 2048386 - Scaffold the Privacy widget on the New Tab page r?#home-newtab-reviewers
Updated•5 months ago
|
Attachment #9598821 -
Attachment description: WIP: Bug 2048386 - Scaffold the Privacy widget on the New Tab page r?#home-newtab-reviewers → Bug 2048386 - Scaffold the Privacy widget on the New Tab page r?#home-newtab-reviewers
Pushed by npypchenko@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/94b4a5711b24
https://hg.mozilla.org/integration/autoland/rev/04ec59ae6f34
Scaffold the Privacy widget on the New Tab page r=fluent-reviewers,reemhamz,bolsson
Comment 3•4 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
status-firefox154:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
Updated•3 months ago
|
QA Whiteboard: [qa-triage-done-c155/b154]
You need to log in
before you can comment on or make changes to this bug.
Description
•