2048425 - [text-box-trim] Implement block container trimming

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Comment 1

[Sajid Anwar [:sajidanwar]]

Attachment: Bug 2048425 - Implement text-box-trim for block containers. r=#layout-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/49018bf901bb
https://hg.mozilla.org/integration/autoland/rev/80d98c36cbf7
Implement text-box-trim for block containers. r=layout-reviewers,jfkthame,emilio

Comment 3

[rperta]

Backed out for causing wr failures at text-box-trim-float-clear-br-002.html
Backout link
Push with failures
Failure log(s)

Comment 4

[Sajid Anwar [:sajidanwar]]

Hm, appears to be sub-pixel behaviors causing failures on Mac and Windows. Some reftest analyzers: macOS debug, Windows 11 opt, Windows 11 debug.

Between these, max difference is <= 207 per channel, <= 202 pixels. That seems like a lot to add to a fuzzy expectation ...

Comment 5

[Sajid Anwar [:sajidanwar]]

Oh, the expectation for this even before my implementation already had Mac and Windows carve-outs. Going to put Mac and Windows back as FAIL, then.

Comment 6

[agoloman]

Backed out for causing wr failures @text-box-trim-start-001.html.

• Backout link
• Push with failures
• Failure Log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/af084e0a5ba7
https://hg.mozilla.org/mozilla-central/rev/7e08d91af09a
Implement text-box-trim for block containers. r=layout-reviewers,jfkthame,emilio

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5a852008860e
https://hg.mozilla.org/integration/autoland/rev/88131739a1f3
Implement text-box-trim for block containers. r=layout-reviewers,jfkthame,emilio

Comment 9

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/88131739a1f3