Closed Bug 2048469 Opened 2 months ago Closed 2 months ago

[wpt-sync] Sync PR 60694 - [Masonry] Apply stacking-axis alignment

Categories

(Core :: Layout: Grid, task, P4)

Product:
Core
Component:
Layout: Grid
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
154 Branch
Tracking Flags:
Tracking Status
firefox154 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 60694 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/60694
Details from upstream follow.

Celeste Pan <celestepan@microsoft.com> wrote:

[Masonry] Apply stacking-axis alignment

Follow-ups will be needed to implement stacking-axis alignment together
with dense-packing, and to add tests to ensure that content alignment
works with stacking-axis alignment.

To account for items which need stacking-axis alignment, we keep track
of the item placed above each track opening. After placement is complete
and track openings are finalized, we perform stacking axis alignment. We
perform stretch alignment at the very end as we need to re-layout the
item and actually add it to the container builder.

Although we are still waiting on the CSSWG on whether or not explicit
sizing should override stretch alignment [1], this change assumes that
we do want to let explicit size override stretch alignment.

Lastly, tests were fixed to have widths/heights that matched with the
track with the largest running position, which is what the ref files had
-- previously the containers were falling short so it looked like the
stretch items weren't properly stretching.

Stacking axis alignment for OOF items are already tested in:
1.third_party/blink/web_tests/external/wpt/css/css-grid/grid-lanes/abspos/column-grid-lanes-alignment.html
2.third_party/blink/web_tests/external/wpt/css/css-grid/grid-lanes/abspos/column-grid-lanes-alignment-ref.html
3.third_party/blink/web_tests/external/wpt/css/css-grid/grid-lanes/abspos/row-grid-lanes-alignment.html
4.third_party/blink/web_tests/external/wpt/css/css-grid/grid-lanes/abspos/row-grid-lanes-alignment-ref.html

[1] https://github.com/w3c/csswg-drafts/issues/13950

Bug: 343257585
Change-Id: I7b1b51448e478dc0d0f762ca1fd6aa58ca2fa701
Reviewed-on: https://chromium-review.googlesource.com/7899886
WPT-Export-Revision: fcad2e6282bb5c641bf3fcfc57d75c510721dc1a

Component: web-platform-tests → Layout: Grid
Product: Testing → Core

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 74 tests

Status Summary

Firefox

PASS: 1
FAIL: 13[GitHub] 73[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

FAIL: 13

Safari

FAIL: 13

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

https://hg.mozilla.org/mozilla-central/rev/27f631d3c703
https://hg.mozilla.org/mozilla-central/rev/b2400076dce6

Status: NEW → RESOLVED
Closed: 2 months ago
status-firefox154: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
You need to log in before you can comment on or make changes to this bug.