Open Bug 2048649 Opened 4 months ago Updated 19 days ago

Deprecate newtab-card-style mixin in favor of widget-base-style for New Tab widgets

Categories

(Firefox :: New Tab Page, task)

Product:
Firefox
Component:
New Tab Page
Type:
task

Tracking

()

People

(Reporter: maxx, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [hnt])

newtab-card-style is a generic card mixin; widget-base-style (content-src/styles/_mixins.scss) is the widget-specific base that adds the shared per-size height (small/medium/large), hover outline, size transitions, and position: relative.

New widgets that follow the scaffold example used newtab-card-style directly and missed that shared sizing -- the Privacy widget (bug 2048387 / meta bug 2048384) rendered a collapsed card with an empty body until it was switched to widget-base-style.

Migrate widget roots in content-src/components/Widgets/*/_*.scss to widget-base-style (FocusTimer and Lists currently include both), update the widgets-scaffold skill's ExampleWidget reference, and assess whether the per-size sizing should move to min-height so widgets can grow with content.

Whiteboard: [hnt]
You need to log in before you can comment on or make changes to this bug.