2048742 - Bootstrap does not download the correct rustup on aarch64 windows

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, enhancement)

Description

[Bas Schouten (:bas.schouten)]

It installs the x86_64 rustup which in turn attempts to install that rust toolchain, it should probably default to the aarch64 toolchain. I have a patch.

Comment 1

[Bas Schouten (:bas.schouten)]

Attachment: Bug 2048742: Fix rust toolchain selection on aarch64 windows host. r=glandium

This makes us correctly download the aarch64 rustup when bootstrapping on aarch64 windows. It re-uses logic from 2 dead functions which it also removes from the places where they seem to have lingered.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cf739c7a6b61
https://hg.mozilla.org/integration/autoland/rev/1efc99d7b7ce
Fix rust toolchain selection on aarch64 windows host. r=glandium

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bfc5c7598353
https://hg.mozilla.org/integration/autoland/rev/53ad17f35d6f
Revert "Bug 2048742: Fix rust toolchain selection on aarch64 windows host. r=glandium" for causing bootstrap bustages.

Comment 4

[Atila Butkovits]

Backed out for causing bootstrap bustages.

Backout link: https://hg.mozilla.org/integration/autoland/rev/53ad17f35d6f

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=1efc99d7b7ce6cd629a215189d050e2296e17363&selectedTaskRun=Eri5Pzj6QTu-eOZIz71cBA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=573919690&repo=autoland&task=Eri5Pzj6QTu-eOZIz71cBA.0&lineNumber=116

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/961e86ae682a
https://hg.mozilla.org/integration/autoland/rev/2de158800af8
Fix rust toolchain selection on aarch64 windows host. r=glandium

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/2de158800af8

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/2de158800af8

Comment 8

[BMO Github Automation]

Authored by https://github.com/Bas-moz
https://github.com/mozilla/enterprise-firefox/commit/cf739c7a6b613f605b59e522ff32846fcc10c543
[enterprise-main] Bug 2048742: Fix rust toolchain selection on aarch64 windows host. r=glandium

Authored by Atila Butkovits
https://github.com/mozilla/enterprise-firefox/commit/bfc5c759835307dc846b4daf34a792075ad800fc
[enterprise-main] Revert "Bug 2048742: Fix rust toolchain selection on aarch64 windows host. r=glandium" for causing bootstrap bustages.

Authored by https://github.com/Bas-moz
https://github.com/mozilla/enterprise-firefox/commit/961e86ae682a45e3b144834d4d997b686883fc5e
[enterprise-main] Bug 2048742: Fix rust toolchain selection on aarch64 windows host. r=glandium