Closed
Bug 204879
Opened 22 years ago
Closed 22 years ago
[AxPlugin] Don't install nsIMozAxPlugin.xpt in COM connect mode
Categories
(Core Graveyard :: Embedding: ActiveX Wrapper, defect)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 203704
People
(Reporter: adamlock, Assigned: adamlock)
References
Details
Attachments
(1 file)
|
1.24 KB,
patch
|
dbradley
:
review+
alecf
:
superreview+
sspitzer
:
approval1.4+
|
Details | Diff | Splinter Review |
nsIMozAxPlugin.xpt doesn't need to be built or installed in COM connect mode
Don't build / install / bundle nsIMozAxPlugin.xpt / .idl when
MOZ_ACTIVEX_SCRIPTING_SUPPORT is defined.
Comment on attachment 122755 [details] [diff] [review]
Patch
Can I have r/sr on this simple makefile change to not export or build
nsIMozAxPlugin.xpt in COM connect mode?
Thanks
Attachment #122755 -
Flags: superreview?(alecf)
Attachment #122755 -
Flags: review?(dbradley)
|
||
Comment 3•22 years ago
|
||
Comment on attachment 122755 [details] [diff] [review]
Patch
sr=alecf
Attachment #122755 -
Flags: superreview?(alecf) → superreview+
|
||
Comment 4•22 years ago
|
||
Comment on attachment 122755 [details] [diff] [review]
Patch
r=dbradley
Attachment #122755 -
Flags: review?(dbradley) → review+
Comment on attachment 122755 [details] [diff] [review]
Patch
Requesting 1.4 approval. A straightforward makefile change to prevent a file
being exported or compiled.
Attachment #122755 -
Flags: approval1.4?
|
||
Comment 6•22 years ago
|
||
Comment on attachment 122755 [details] [diff] [review]
Patch
a=sspitzer for 1.4 final
Attachment #122755 -
Flags: approval1.4? → approval1.4+
Fix is checked in
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Backed the change out, I'll dupe this bug into bug 203704 which deals with
plugin cleanup
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Dupe bug 203704
*** This bug has been marked as a duplicate of 203704 ***
Status: REOPENED → RESOLVED
Closed: 22 years ago → 22 years ago
Resolution: --- → DUPLICATE
|
||
Updated•13 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•