2048944 - Cannot detect ISO-2022-JP

Status: RESOLVED FIXED

(Core :: Internationalization, defect, P3)

Description

[Masatoshi Kimura [:emk]]

I know we deliberately disabled auto-detection, but Chrome detects ISO-2022-JP on this page.
The difference may cause script injection (think if the MIME type is text/html and \x1b$B<script>alert()</script>\x1b(B exists on this page.

Comment 2

[Henri Sivonen (:hsivonen)]

Attachment: Bug 2048944 - Restore ISO-2022-JP detection for plain text.

Comment 3

[Henri Sivonen (:hsivonen)]

It would have been nice if https://github.com/mozilla/standards-positions/issues/1199 had emphasized that Chrome was retaining autodetection for plain text.

I've attached a patch that tries to restore autodetection support for plain text. I have a feeling that I might be missing some cases. This doesn't have tests, yet.

Comment 4

[Dianna Smith [:diannaS]]

:hsivonen hi! can you set a priority/severity for this?

Comment 5

[Henri Sivonen (:hsivonen)]

S3, because despite the lack of workaround, the impact is relatively limited: Mostly archives of mailing lists served over HTTP.

Comment 6

[Henri Sivonen (:hsivonen)]

https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=59934

Comment 7

[Henri Sivonen (:hsivonen)]

https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=61888

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e78b04b8ca35
https://hg.mozilla.org/integration/autoland/rev/d0ac3f482da5
Restore ISO-2022-JP detection for plain text. r=emk

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d0ac3f482da5

Comment 10

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:hsivonen, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox153 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Given that Henri isn't available to do so, can you please nominate this for Beta uplift?

Comment 12

[Masatoshi Kimura [:emk]]

Attachment: Bug 2048944 - Restore ISO-2022-JP detection for plain text.

Original Revision: https://phabricator.services.mozilla.com/D308005

Comment 13

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Users cannot read plain text files encoded in ISO-2022-JP.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Only partially restores previous code paths.
• String changes made/needed?: No
• Is Android affected?: yes

Comment 14

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/aaf40d8834c2
https://hg.mozilla.org/releases/mozilla-beta/rev/6b5e8e0e0aea