2049014 - Find Events check mark indicator reversed

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[John Littleton]

Attachment: Thunderbird154.0a1DailyFindEventIndicatorErr.jpg

Steps to reproduce:

Go to "Calendar" tab. Select "Events and Tasks" menu item. Scroll down "Events and Tasks" menu to "Find Events". Select "Find Events".

Actual results:

"Find Events" menu item shows check mark as selected with no display of "Find Events" search dialog at top of calendar. Unselecting/clearing "Find Events" menu item clears check mark for "Find Events" and displays "Find Events" search display dialog at top of calendar. "Find Events" check mark indicator is reversed.

Expected results:

When "Find Events" menu item check mark indicator is clear/unselected there should be no display of "Find Events" search dialog at top of calendar. When "Find Events" menu item check mark indicator shows/is selected "Find Events" search display dialog should display at top of calendar. "Find Events" check mark indicator is reversed.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug 2049014 - Synchronize the ShowUnifinder menu with the Unifinder. r=#thunderbird-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/90f6d9716d8d
Synchronize the ShowUnifinder menu with the Unifinder. r=mkmelin

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 9599476 [details]
Bug 2049014 - Synchronize the ShowUnifinder menu with the Unifinder. r=#thunderbird-reviewers

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: Menuitem not always synchronized with the unifinder state
• User impact if declined: Menuitem not always synchronized with the unifinder state
• Is this code covered by automated tests?: No
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: N/A
• Needs manual test from QA?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): One simple JS change
• Does the fix cause any migrations to be skipped?: No
• String changes made/needed: no

Comment 4

[Corey Bryant]

Comment on attachment 9599476 [details]
Bug 2049014 - Synchronize the ShowUnifinder menu with the Unifinder. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 5

[Daniel Darnell [:dandarnell]]

Thunderbird 153.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/27df3ca2ca73