Closed Bug 2049031 Opened 5 months ago Closed 14 days ago

Cleanup all code related to the old "Privacy" pane in about:preferences

Categories

(Firefox :: Settings UI, task)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: hjones, Assigned: akulyk)

References

(Blocks 1 open bug)

Details

(Whiteboard: [recomp])

Attachments

(1 external file)

Once we are confident all the new Privacy and security settings are working as expected / the SRD pref has been flipped for a while we should go back and cleanup all the unused code related to the old pane. Specifically we should:

  • delete browser/components/preferences/privacy.js and cleanup any references
  • delete browser/components/preferences/privacy.inc.xhtml and cleanup any references
    • check to see if there are any CSS styles, images, or other assets that are specific to that xhtml file and delete them
    • check to see if there are any Fluent ID that will be completely unused after we remove this markup/JS code and delete them
  • remove any references to gPrivacyPane
Blocks: 2078651
No longer blocks: 2078651
Duplicate of this bug: 2027797
Assignee: nobody → akulyk

privacy.js used to import permissions-data.mjs and passwords-autofill.mjs on
page load. privacy.mjs depends on preferences and settings they register, so
it now imports them itself.

Since permissions-data.mjs now loads with its pane, notificationSettingsEntry
can render before its async getControlConfig() resolves. Its static l10nId is
now the message without a $count argument.

The FIPS alert in passwords-autofill.mjs read its strings from elements that
only existed in privacy.inc.xhtml; it now formats them through Fluent. The
privacy-pane-loaded handler in FormAutofillParent only served the legacy pane.

The legacy setting groups were removed, and their redesigned replacements lost the 2 suffix.

Pushed by akulyk@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/533878e86575 https://hg.mozilla.org/integration/autoland/rev/eee252af7d73 Cleanup all code related to the old "Privacy" pane in about:preferences r=settings-reviewers,fluent-reviewers,desktop-theme-reviewers,credential-management-reviewers,reusable-components-reviewers,hjones,timhuang,flod,dimi
Status: NEW → RESOLVED
Closed: 14 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: