2049086 - [IPC Urlbar] Remove the test-only listener API from UrlbarParentController and update its unit tests

Status: ASSIGNED

(Firefox :: Address Bar, task)

Description

[Dão Gottwald [:dao]]

In bug 2044950, listener dispatch moved to UrlbarChildController, which owns the listener set; UrlbarParentController delegates to it via setListenerHost(). The parent kept its own _listeners set and addListener/removeListener/notify only as a standalone fallback, used solely by xpcshell unit tests that construct a bare parent via UrlbarTestUtils.newMockController.

As mbeier noted in https://phabricator.services.mozilla.com/D304697#inline-1658130, there are only 4 such usages in unit tests (browser tests already go through UrlbarChildController::addListener), and some of them test the test-only UrlbarParentController::addListener path.

Update those unit tests so they no longer rely on the test-only listener API on UrlbarParentController, then remove the parent's standalone listener fallback (the _listeners set and the _listenerHost delegation in addListener/removeListener/notify), leaving listener registration and dispatch solely on UrlbarChildController.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 2049086 - [IPC Urlbar] Remove the test-only listener API from UrlbarParentController and update its unit tests. r?mbeier