Open Bug 2049087 Opened 2 days ago Updated 1 day ago

[IPC Urlbar] Phase 1: Route UrlbarView's provider lookups through the controller instead of UrlbarParentController.manager

Categories

(Firefox :: Address Bar, task)

task

Tracking

()

ASSIGNED

People

(Reporter: dao, Assigned: dao)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Whiteboard: [sng][mcab-hnt])

Attachments

(1 file)

After bug 2044950 split the controller, UrlbarView still reaches the parent-process ProvidersManager through controller.manager: its #providersManager getter calls getProvider(...) and then getViewTemplate/getViewUpdate/onBeforeSelection/getResultCommands on the returned provider. That works while <moz-urlbar> is in the parent process but won't survive it running in a content process.

Add controller-side helpers (getViewTemplate, getViewUpdate, onBeforeSelection, getResultCommands) on UrlbarParentController, forwarded by UrlbarChildController, and update UrlbarView to call those instead — removing the #providersManager getter and the child's manager forward. No behavior change in chrome (synchronous, in-process); marshalling for the content-process case is a later step.

Summary: Route UrlbarView's provider lookups through the controller instead of UrlbarParentController.manager → [IPC Urlbar] Phase 1: Route UrlbarView's provider lookups through the controller instead of UrlbarParentController.manager
Blocks: 2049112
No longer blocks: 2010269
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: