Closed Bug 2049130 Opened 1 month ago Closed 28 days ago

[wpt-sync] Sync PR 59594 - Reject strings in `ReadableStream.from`

Tracking

()

Status:

RESOLVED FIXED

Milestone:

154 Branch

Tracking Flags:

Tracking

Status

firefox154

---

fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Depends on 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Description

•

1 month ago

Sync web-platform-tests PR 59594 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/59594
Details from upstream follow.

Mattias Buelens <mattias@buelens.com> wrote:

Reject strings in ReadableStream.from

This aligns the tests with the expected behavior of async_sequence in Web IDL.

Accompanies https://github.com/whatwg/streams/pull/1372.

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

1 month ago

Component: web-platform-tests → DOM: Streams

Product: Testing → Core

Mattias Buelens

Updated

•

1 month ago

Depends on: 2052661

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 1

•

1 month ago

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=58a872f31095099c0c26bc914c7616660e233109

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 2

•

1 month ago

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 83 tests and 3 subtests

Status Summary

Firefox

OK : 4[GitHub] 75[Gecko-android-em-14-x86_64-debug-geckoview] 79[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 4[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 196[GitHub] 1308[Gecko-android-em-14-x86_64-debug-geckoview] 1387[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 4[GitHub] 67[Gecko-android-em-14-x86_64-debug-geckoview] 68[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

OK : 4
PASS: 56
FAIL: 144

Safari

OK : 4
PASS: 200

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/streams/readable-streams/from.any.sharedworker.html [wpt.fyi]
- ReadableStream.from throws on invalid iterables; specifically a string: FAIL
/streams/readable-streams/from.any.html [wpt.fyi]
- ReadableStream.from throws on invalid iterables; specifically a string: FAIL
/streams/readable-streams/from.any.serviceworker.html [wpt.fyi]
- ReadableStream.from throws on invalid iterables; specifically a string: FAIL
/streams/readable-streams/from.any.worker.html [wpt.fyi]
- ReadableStream.from throws on invalid iterables; specifically a string: FAIL

New Tests That Don't Pass

/streams/readable-streams/async-iterator.any.sharedworker.html [wpt.fyi]
- Async iterator instances should have the correct list of properties: FAIL
- return(); next() [no awaiting]: FAIL
- return(); next() with delayed cancel() [no awaiting]: FAIL
- return(); return() [no awaiting]: FAIL
/streams/readable-streams/async-iterator.any.serviceworker.html [wpt.fyi]
- Async iterator instances should have the correct list of properties: FAIL
- return(); next() [no awaiting]: FAIL
- return(); next() with delayed cancel() [no awaiting]: FAIL
- return(); return() [no awaiting]: FAIL
/streams/readable-streams/async-iterator.any.html [wpt.fyi]
- Async iterator instances should have the correct list of properties: FAIL
- return(); next() [no awaiting]: FAIL
- return(); next() with delayed cancel() [no awaiting]: FAIL
- return(); return() [no awaiting]: FAIL
/streams/readable-streams/async-iterator.any.worker.html [wpt.fyi]
- Async iterator instances should have the correct list of properties: FAIL
- return(); next() [no awaiting]: FAIL
- return(); next() with delayed cancel() [no awaiting]: FAIL
- return(); return() [no awaiting]: FAIL
/streams/readable-streams/bad-underlying-sources.any.serviceworker.html [wpt.fyi]: OK [Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt], SKIP [Gecko-android-em-14-x86_64-debug-geckoview]
/streams/readable-streams/count-queuing-strategy-integration.any.worker.html [wpt.fyi]: OK [Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt], SKIP [Gecko-android-em-14-x86_64-debug-geckoview]
/streams/readable-streams/floating-point-total-queue-size.any.sharedworker.html [wpt.fyi]: OK [Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt], SKIP [Gecko-android-em-14-x86_64-debug-geckoview]
/streams/readable-streams/from.any.sharedworker.html [wpt.fyi]
- ReadableStream.from throws on invalid iterables; specifically a string: FAIL (Chrome: PASS, Safari: PASS)
/streams/readable-streams/from.any.html [wpt.fyi]
- ReadableStream.from throws on invalid iterables; specifically a string: FAIL (Chrome: PASS, Safari: PASS)
/streams/readable-streams/from.any.serviceworker.html [wpt.fyi]
- ReadableStream.from throws on invalid iterables; specifically a string: FAIL (Chrome: PASS, Safari: PASS)
/streams/readable-streams/from.any.worker.html [wpt.fyi]: OK [Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt, GitHub], SKIP [Gecko-android-em-14-x86_64-debug-geckoview] (Chrome: OK, Safari: OK)
- ReadableStream.from throws on invalid iterables; specifically a string: FAIL (Chrome: PASS, Safari: PASS)
/streams/readable-streams/owning-type-message-port.tentative.any.worker.html [wpt.fyi]
- Transferred MessageChannel works as expected: FAIL
- Second branch of owning ReadableStream tee should end up into errors with transfer only values: FAIL
/streams/readable-streams/owning-type-message-port.tentative.any.sharedworker.html [wpt.fyi]
- Transferred MessageChannel works as expected: FAIL
- Second branch of owning ReadableStream tee should end up into errors with transfer only values: FAIL
/streams/readable-streams/owning-type-message-port.tentative.any.serviceworker.html [wpt.fyi]
- Transferred MessageChannel works as expected: FAIL
- Second branch of owning ReadableStream tee should end up into errors with transfer only values: FAIL
/streams/readable-streams/owning-type-message-port.tentative.any.html [wpt.fyi]
- Transferred MessageChannel works as expected: FAIL
- Second branch of owning ReadableStream tee should end up into errors with transfer only values: FAIL
/streams/readable-streams/owning-type-video-frame.tentative.any.sharedworker.html [wpt.fyi]
- ReadableStream of type owning should close serialized chunks: FAIL
- ReadableStream of type owning should transfer JS chunks with transferred values: FAIL
- ReadableStream of type owning should error when trying to enqueue not serializable values: FAIL
- ReadableStream of type owning should clone serializable objects when teeing: FAIL
- ReadableStream of type owning should clone JS Objects with serializables when teeing: FAIL
/streams/readable-streams/owning-type-video-frame.tentative.any.serviceworker.html [wpt.fyi]
- ReadableStream of type owning should close serialized chunks: FAIL
- ReadableStream of type owning should transfer JS chunks with transferred values: FAIL
- ReadableStream of type owning should error when trying to enqueue not serializable values: FAIL
- ReadableStream of type owning should clone serializable objects when teeing: FAIL
- ReadableStream of type owning should clone JS Objects with serializables when teeing: FAIL
/streams/readable-streams/owning-type-video-frame.tentative.any.html [wpt.fyi]
- ReadableStream of type owning should close serialized chunks: FAIL
- ReadableStream of type owning should transfer JS chunks with transferred values: FAIL
- ReadableStream of type owning should error when trying to enqueue not serializable values: FAIL
- ReadableStream of type owning should clone serializable objects when teeing: FAIL
- ReadableStream of type owning should clone JS Objects with serializables when teeing: FAIL
/streams/readable-streams/owning-type-video-frame.tentative.any.worker.html [wpt.fyi]
- ReadableStream of type owning should close serialized chunks: FAIL
- ReadableStream of type owning should transfer JS chunks with transferred values: FAIL
- ReadableStream of type owning should error when trying to enqueue not serializable values: FAIL
- ReadableStream of type owning should clone serializable objects when teeing: FAIL
- ReadableStream of type owning should clone JS Objects with serializables when teeing: FAIL
/streams/readable-streams/owning-type.tentative.any.serviceworker.html [wpt.fyi]
- ReadableStream can be constructed with owning type: FAIL
- ReadableStream of type owning should call start with a ReadableStreamDefaultController: FAIL
- ReadableStream should be able to call enqueue with an empty transfer list: FAIL
- ReadableStream should check transfer parameter: FAIL
- ReadableStream of type owning should transfer enqueued chunks: FAIL
/streams/readable-streams/owning-type.tentative.any.worker.html [wpt.fyi]
- ReadableStream can be constructed with owning type: FAIL
- ReadableStream of type owning should call start with a ReadableStreamDefaultController: FAIL
- ReadableStream should be able to call enqueue with an empty transfer list: FAIL
- ReadableStream should check transfer parameter: FAIL
- ReadableStream of type owning should transfer enqueued chunks: FAIL
/streams/readable-streams/owning-type.tentative.any.html [wpt.fyi]
- ReadableStream can be constructed with owning type: FAIL
- ReadableStream of type owning should call start with a ReadableStreamDefaultController: FAIL
- ReadableStream should be able to call enqueue with an empty transfer list: FAIL
- ReadableStream should check transfer parameter: FAIL
- ReadableStream of type owning should transfer enqueued chunks: FAIL
/streams/readable-streams/owning-type.tentative.any.sharedworker.html [wpt.fyi]
- ReadableStream can be constructed with owning type: FAIL
- ReadableStream of type owning should call start with a ReadableStreamDefaultController: FAIL
- ReadableStream should be able to call enqueue with an empty transfer list: FAIL
- ReadableStream should check transfer parameter: FAIL
- ReadableStream of type owning should transfer enqueued chunks: FAIL

Tests Disabled in Gecko Infrastructure

/streams/readable-streams/bad-underlying-sources.any.serviceworker.html [wpt.fyi]: OK [Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt], SKIP [Gecko-android-em-14-x86_64-debug-geckoview]
/streams/readable-streams/count-queuing-strategy-integration.any.worker.html [wpt.fyi]: OK [Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt], SKIP [Gecko-android-em-14-x86_64-debug-geckoview]
/streams/readable-streams/floating-point-total-queue-size.any.sharedworker.html [wpt.fyi]: OK [Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt], SKIP [Gecko-android-em-14-x86_64-debug-geckoview]
/streams/readable-streams/from.any.worker.html [wpt.fyi]: OK [Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt, GitHub], SKIP [Gecko-android-em-14-x86_64-debug-geckoview] (Chrome: OK, Safari: OK)

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

29 days ago

Depends on: 2054639

Pulsebot

Comment 3

•

29 days ago

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/59b2db11673e https://hg.mozilla.org/integration/autoland/rev/7f6da30634fe [wpt PR 59594] - Reject strings in `ReadableStream.from`, a=testonly https://github.com/mozilla-firefox/firefox/commit/78e88438635c https://hg.mozilla.org/integration/autoland/rev/b2804b03e946 [wpt PR 59594] - Update wpt metadata, a=testonly

Serban Stanca [:SerbanS]

Comment 4

•

28 days ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/7f6da30634fe
https://hg.mozilla.org/mozilla-central/rev/b2804b03e946

Status: NEW → RESOLVED

Closed: 28 days ago

status-firefox154: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 154 Branch

You need to log in before you can comment on or make changes to this bug.

Bugzilla

[wpt-sync] Sync PR 59594 - Reject strings in `ReadableStream.from`

Categories

(Core :: DOM: Streams, task, P4)

Tracking

()

People

(Reporter: wpt-sync, Unassigned)

References

(Depends on 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Crash Data

Security

(public)

User Story

Description

Updated

Updated

Comment 1

Comment 2

CI Results

Status Summary

Firefox

Chrome

Safari

Links

Details

Firefox-only Failures

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

Updated

Comment 3

Comment 4