2049251 - File Dialog (Save as) ignores "Enter" key on saving since firefox 152.0

Status: RESOLVED DUPLICATE of bug 2047865

(Core :: Widget: Gtk, defect)

Description

[Hanno Boeck]

Since the Firefox version (152.0), something with the file dialog seems broken. (Linux/Gtk+, on Gentoo Linux, LXQT Environment)

When I do rightclick->"Save Page As" and then just type a filename and press "Enter", I'd expect the file to be saved. However, pressing Enter is simply ignored and the only way to save the file is to click the "Save" Button with the mouse (meaning, effectively, I cannot save something with the keyboard only, which is very annoying).

I just checked with a manually downloaded version of firefox 151.4 and it does not happen there, so it seems something broke with 152.0.

Comment 1

[Robert Longson [:longsonr]]

Could you establish a more precise regression range using mozregression please?

Comment 2

[Jan Claeys]

You can use Alt+S to save using the keyboard as a workaround.

Another thing that might be relevant: normally the Save button is coloured green; this indicates it is the default button and is why the Enter key activates it, but now it is no longer green (which is why Enter no longer works).

Comment 3

[Jan Claeys]

mozregression found this range:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=04f987534771f13e35e82074986a422e4b13b44a&tochange=4201ad8bbb183a6ae00df4cfd5d775a976564828

Although it fixes something (unclear to me what, the bug is hidden) for the file picker for opening files rather than saving them, It's the only one mentioning file picker in its commit message, so this patch might be related:
https://hg-edge.mozilla.org/mozilla-central/rev/984fa350913586b986271852a6b29b0261a26ddb

Comment 4

[Jan Claeys]

Some other issue I discovered which is most likely related to disabling the default behaviour: the save dialog no longer checks if a file exists, so it's very easy to accidentally overwrite a file with the same name and lose data.

Comment 5

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 2033848