2049293 - [moz-phab] Init errors get swallowed by Jujutsu backend

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect)

Description

[Erich Gubler [:ErichDonGubler] (he/him)]

moz-phab version (from moz-phab version): 2.15.2

Just had an issue where I had forgotten to add .arcconfig to my sparse set of files in a sparse jj workspace. I had to work around this issue to figure out what the actual problem was! Sigh.

Comment 1

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 2049293 - diag(git): log bare repo path at debug level r=sheehan

Comment 2

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 2049293 - diag(jj): confirm successful Git repo init. r=sheehan

Comment 3

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 2049293 - chore(jj): clarify comment on raising `Error`s r=sheehan

Comment 4

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 2049293 - fix(jj): raise `Error` instead of `ValueError` for Git init. r=sheehan

This will surface issues instead of them getting swallowed.

Comment 5

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 2049293 - diag(jj): add exception msg. for Git init. issues r=sheehan

This would have saved me some headache trying to figure out why a sparse
workspace was stuck on not having .arcconfig checked out yet.

Comment 6

[BMO Github Automation]

Authored by https://github.com/ErichDonGubler
https://github.com/mozilla-conduit/review/commit/bf45bd7caa456b129a814bf007f6a8ca25d76d6e
[main] Bug 2049293 - diag(git): log bare repo path at debug level r=sheehan

Authored by https://github.com/ErichDonGubler
https://github.com/mozilla-conduit/review/commit/0f1026a8eb90ac1caf6fa527965d050867bc103f
[main] Bug 2049293 - diag(jj): confirm successful Git repo init. r=sheehan

Authored by https://github.com/ErichDonGubler
https://github.com/mozilla-conduit/review/commit/00bb4e7ac9de2adbe8eadd47d86a67c49296da91
[main] Bug 2049293 - chore(jj): clarify comment on raising Errors r=sheehan

Authored by https://github.com/ErichDonGubler
https://github.com/mozilla-conduit/review/commit/789e8886077e20213b9d3506b03efa4869cbabd2
[main] Bug 2049293 - fix(jj): raise Error instead of ValueError for Git init. r=sheehan

Authored by https://github.com/ErichDonGubler
https://github.com/mozilla-conduit/review/commit/1256af112e6fa4cd6278269498a5ba89428cccec
[main] Bug 2049293 - diag(jj): add exception msg. for Git init. issues r=sheehan