attachment view broken on cvs tip

RESOLVED FIXED in Bugzilla 2.18

Status

()

defect
RESOLVED FIXED
16 years ago
7 years ago

People

(Reporter: john, Assigned: myk)

Tracking

unspecified
Bugzilla 2.18
x86
Windows XP
Dependency tree / graph
Bug Flags:
approval +

Details

()

Attachments

(1 attachment)

Attachment view gives a server error on cvs tip.  I ran attachment.cgi from
bugzilla-tip directly and got this result, from which I infer that perhaps
Content-disposition is messed up with an extra newline (but I really don't know
for sure what's up):

[jkeiser@landfill bugzilla-tip]$ ./attachment.cgi id=52\&action=view | head
Content-length: 2012
Content-disposition="inline; filename=diff.u
"
Content-Type: text/plain; name="diff.u"

Index: walletOverlay.js
===================================================================
RCS file: /cvsroot/mozilla/extensions/wallet/resources/content/walletOverlay.js,
v
retrieving revision 1.20
diff -u -r1.20 walletOverlay.js
Posted patch PatchSplinter Review
Yep, that was it.  This fixes the problem.
This is a regression of bug 201816.
Blocks: 201816
Comment on attachment 122809 [details] [diff] [review]
Patch

Yup, this fixes it. r=myk
Attachment #122809 - Flags: review+
Flags: approval+
Fix checked in.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Bugzilla 2.18
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.