204964 - attachment view broken on cvs tip

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[John Keiser (jkeiser)]

Attachment view gives a server error on cvs tip.  I ran attachment.cgi from
bugzilla-tip directly and got this result, from which I infer that perhaps
Content-disposition is messed up with an extra newline (but I really don't know
for sure what's up):

[jkeiser@landfill bugzilla-tip]$ ./attachment.cgi id=52\&action=view | head
Content-length: 2012
Content-disposition="inline; filename=diff.u
"
Content-Type: text/plain; name="diff.u"

Index: walletOverlay.js
===================================================================
RCS file: /cvsroot/mozilla/extensions/wallet/resources/content/walletOverlay.js,
v
retrieving revision 1.20
diff -u -r1.20 walletOverlay.js

Comment 1

[John Keiser (jkeiser)]

Attachment: Patch

Yep, that was it.  This fixes the problem.

Comment 2

[John Keiser (jkeiser)]

This is a regression of bug 201816.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 122809 [details] [diff] [review]
Patch

Yup, this fixes it. r=myk

Comment 4

[John Keiser (jkeiser)]

Fix checked in.