2049720 - [GTK] text/plain is missing from dataTransfer.types when dropping content from an external application

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[moriyama164]

Attachment: droptest.html

Impact

This causes the following issues:

• Dropping selected text from another application onto the tab bar or URL bar does not trigger a search.
• Dropping an item (text, URL, file, etc.) from another application into a textarea or input element is not inserted as plain text.

Tested platforms

• Affected platforms: Gentoo Linux (without systemd)
  • DE: KDE Plasma 6.6.5 (X11 and Wayland)
  • GTK version: 3.24.51
• Unaffected platforms: Windows 10 on Oracle VirtualBox

Steps to reproduce

1. Start Nightly.
2. Open the attached HTML page in Nightly.
3. Start another application (e.g. another web browser).
4. Select any text from the other application and drag and drop it onto the "drop here" area in the test page in Nightly.

Actual result

You will see an alert dialog whose message does not include text/plain, as shown below.

event.dataTransfer.types:

    text/html

Expected result

You will see an alert dialog whose message includes text/plain, as shown below.

event.dataTransfer.types:

    text/html
    text/plain

Regression range

• https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=848035deee86001883fe0d0bf6766118ba97d1df&tochange=b5bdfbf2a8fa897923f04528056504ef7c96e064

Comment 1

[BugBot [:suhaib / :marco]]

:stransky, since you are the author of the regressor, bug 2025329, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Will look at it. We moved back to Gtk implementation here so it should be working...

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 2049720 [Linux] Don't use strlen to check D&D data sizes r?emilio

gtk_selection_data_get_length() returns data len without trailing null char.
Also we may get UTF-8 string with nested null chars.
There's no point to compare len returned from srtlen() and gtk_selection_data_get_length() as
they return different values. Just use data len we get from Gtk, use use exact text size anyway
as we convert it to UTF-16.

Comment 4

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 2025329

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a4d736b37a57
https://hg.mozilla.org/integration/autoland/rev/6adc8af16584
[Linux] Don't use strlen to check D&D data sizes r=jhorak

Comment 6

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/6adc8af16584

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 2049720 [Linux] Don't use strlen to check D&D data sizes r?emilio

gtk_selection_data_get_length() returns data len without trailing null char.
Also we may get UTF-8 string with nested null chars.
There's no point to compare len returned from srtlen() and gtk_selection_data_get_length() as
they return different values. Just use data len we get from Gtk, use use exact text size anyway
as we convert it to UTF-16.

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9606513 [details]
Bug 2049720 [Linux] Don't use strlen to check D&D data sizes r?emilio

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Text D&D is broken on Linux.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Remove newly added text length check.
• String changes made/needed: none
• Is Android affected?: No

Comment 9

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/ecb0991bc157
https://hg.mozilla.org/releases/mozilla-beta/rev/f3ba77223ffc