2049750 - "Swipe toolbar vertically to see open tabs" interferes with tab bar scrolling

Status: VERIFIED FIXED

(Firefox for Android :: Toolbar, defect)

Description

[Kestrel]

Attachment: Scrolling tab bar often unresponsive

STR:

1. Launch latest Android Nightly 154.0a1.
2. Enable Settings > Customize > "Show tab bar" and "Swipe toolbar vertically to see open tabs" (default).
3. Open enough tabs for the tab bar to overflow.
4. Scroll the tab bar horizontally backwards and forwards several times by swiping it.

Expected:
Tab bar scrolls reliably with horizontal swipes.

Actual:
Tab bar often gets stuck and does not respond to horizontal swipes.

Works consistently with "Swipe toolbar vertically to see open tabs" disabled.

Vertical swipe gesture should not apply to the tab bar or should not be so sensitive to gestures with a vertical component.

Regressed by Bug 2020810.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:petru, since you are the author of the regressor, bug 2020810, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 2049750 - Avoid consuming horizontal swipes in toolbar's vertical gestures handler r=#android-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e9fdd7b0ac69
https://hg.mozilla.org/integration/autoland/rev/c83a9b2bdfa3
Avoid consuming horizontal swipes in toolbar's vertical gestures handler r=android-reviewers,mcarare

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c83a9b2bdfa3

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:petru, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox153 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Mira Lobontiu (Android QA)]

Verified as fixed on the latest Firefox for Android Nightly 154.0a1 from 6/28 using a Samsung Galaxy S24 (Android 16), and a Motorola Moto G30 (Android 12).

Comment 7

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: When inferring whether the current user gesture is a swipe down to open the tabstray we might inadvertently consume horizontal swipes also
  And breaking other app functionalities like scrolling the tab strip horizontally.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: https://bugzilla.mozilla.org/show_bug.cgi?id=2049750#c0
• Risk associated with taking this patch: low
• Explanation of risk level: Small, targeted change, verified by QA.
• String changes made/needed?: --
• Is Android affected?: yes

Comment 8

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 2049750 - Avoid consuming horizontal swipes in toolbar's vertical gestures handler

Original Revision: https://phabricator.services.mozilla.com/D308466

Comment 9

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: When inferring whether the current user gesture is a swipe down to open the tabstray we might inadvertently consume horizontal swipes also
  And breaking other app functionalities like scrolling the tab strip horizontally.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: https://bugzilla.mozilla.org/show_bug.cgi?id=2049750#c0
• Risk associated with taking this patch: low
• Explanation of risk level: Small, targeted change, verified by QA.
• String changes made/needed?: --
• Is Android affected?: yes

Comment 10

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 2049750 - Avoid consuming horizontal swipes in toolbar's vertical gestures handler

Original Revision: https://phabricator.services.mozilla.com/D308466

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Can we give this bug a severity?

Comment 12

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/26a3fe2dc89f
https://hg.mozilla.org/releases/mozilla-beta/rev/1b2556008706

Comment 13

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/5f263b3da570
https://hg.mozilla.org/releases/mozilla-release/rev/44836991e03a

Comment 14

[Mira Lobontiu (Android QA)]

Verified as fixed on Beta 153.0b8, using a Pixel 6 (Android 17), and a Samsung Galaxy Z Fold 4 (Android 16).
Leaving the qe-verify+ flag to verify the fix also on 152 version.

Comment 15

[Mira Lobontiu (Android QA)]

Verified as fixed on 152.0.5 dot release, using a Xiaomi Poco X7 Pro (Android 16), and a Samsung Galaxy Z Fold 4 (Android 16).