2049877 - Build UI to control the browser icon in Settings

Status: RESOLVED FIXED

(Toolkit :: Preferences, enhancement)

Description

[Mike Conley (:mconley) (:⚙️)]

This should be disabled by default, and should only appear when enabled for Windows non-MSIX builds.

Working off of this Figma: https://www.figma.com/design/MPYRmdy1F5sLL0cyhkmAAs/NPO-Experiments-2026?node-id=2003-28001&m=dev

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: WIP: Bug 2049877 - Add UI for setting custom launcher icons, disabled by default. Also add new variants. r?nrishel,hjones

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 2049877 - Add custom browser icon variants and embed them as executable resources. r?nrishel

Adds the pixelated, minimal and momo icon variants, embeds them as PE
resources, and registers them (with their about:settings metadata) in the
CustomIconManager catalog.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 2049877 - Add about:settings UI for choosing a custom browser icon. r?hjones

Adds the Browser icon entry under Appearance and its picker sub-pane (Basic and
Bonus sets), gated behind browser.shell.customIcon.enabled, which is disabled
by default while the feature is in development.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 2049877 - Extract DefaultBrowserHelper into its own module. r?hjones

Moves the DefaultBrowserHelper object out of main.js into a new
DefaultBrowserHelper.mjs, imported with global: current so window/location/
document still resolve to the preferences window. The object is moved verbatim;
the only adaptations are those required to live in a module: it is exported,
getShellService() is qualified as window.getShellService(), and the GIO service
uses a module-local lazy getter. No behavior change.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 2049877 - Make DefaultBrowserHelper support multiple poll subscribers. r?hjones

Generalizes the default-browser poll from a single callback to a set of
subscribers. pollForDefaultChanges() now adds a listener and returns an
unsubscribe function, starting the timer on the first subscriber and stopping
it once the last unsubscribes. Also recognizes the browserIcon sub-pane in the
poll gate so it stays live there.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e0dd3ce99333
https://hg.mozilla.org/integration/autoland/rev/8360b946e88b
Add custom browser icon variants and embed them as executable resources. r=nrishel
https://github.com/mozilla-firefox/firefox/commit/48c867254de1
https://hg.mozilla.org/integration/autoland/rev/26dddfc649fb
Extract DefaultBrowserHelper into its own module. r=hjones
https://github.com/mozilla-firefox/firefox/commit/867b99993b15
https://hg.mozilla.org/integration/autoland/rev/8eacf3fc2970
Make DefaultBrowserHelper support multiple poll subscribers. r=hjones

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/8360b946e88b
https://hg.mozilla.org/mozilla-central/rev/26dddfc649fb
https://hg.mozilla.org/mozilla-central/rev/8eacf3fc2970

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e4cbc1c992a2
https://hg.mozilla.org/integration/autoland/rev/cfc904a929c6
Add about:settings UI for choosing a custom browser icon. r=hjones,fluent-reviewers,desktop-theme-reviewers,flod

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/cfc904a929c6