2049942 - Use DisassemblerSpew for riscv64

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement)

Description

[André Bargull [:anba]]

DisassemblerSpew supports tracking label identifiers, which makes reading the codegen jit spew much easier.

Example - Codegen jit spew for i ? 1 : 0 now prints:

[Codegen]                                 # LIR=TestIAndBranch
[Codegen] [h] 000048 00028063       beq       t0, zero, 0 -> 1003f
[Codegen] --------------------------------
[Codegen] [h]                  1004:
[Codegen]                                 # LIR=Integer
[Codegen] [h] 00004c 00100293       li        t0, 1
[Codegen]                                 # LIR=Goto
[Codegen] [h] 000050 0000006f       j         0 -> 1005f
[Codegen] --------------------------------
[Codegen] [h]                  1003:
[Codegen]                                 # LIR=Integer
[Codegen] [h] 000054 00000293       mv        t0, zero
[Codegen]                                 # LIR=Goto
[Codegen] --------------------------------
[Codegen] [h]                  1005:

Comment 1

[André Bargull [:anba]]

Attachment: Bug 2049942 - Part 1: Don't pass implicit zero offset. r=jandem!

Don't pass the implicit zero offset, so these methods don't require
changing when LabelDoc is added in part 2.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 2049942 - Part 2: Pass LabelDoc to branch methods. r=jandem!

Pass LabelDoc to branch methods in preparation for part 4 when
DisassemblerSpew gets enabled for riscv64.

Comment 3

[André Bargull [:anba]]

Attachment: Bug 2049942 - Part 3: Remove some codegen jitspew calls. r=jandem!

DisassemblerSpew adds a tracking id to its output to differentiate concurrent
assemblers. When using JitSpew(JitSpew_Codegen, ...), the DisassemblerSpew is
bypassed and no tracking id is emitted. To make the codegen jitspew less confusing
avoid JitSpew(JitSpew_Codegen, ...) and either replace it with comment(...) or
remove it altogether.

Comment 4

[André Bargull [:anba]]

Attachment: Bug 2049942 - Part 4: Use DisassemblerSpew for riscv64. r=jandem!

DisassemblerSpew supports tracking label identifiers, which makes reading the
codegen jit spew much easier.

Example - Codegen jit spew for i ? 1 : 0 now prints:

[Codegen]                                 # LIR=TestIAndBranch
[Codegen] [h] 000048 00028063       beq       t0, zero, 0 -> 1003f
[Codegen] --------------------------------
[Codegen] [h]                  1004:
[Codegen]                                 # LIR=Integer
[Codegen] [h] 00004c 00100293       li        t0, 1
[Codegen]                                 # LIR=Goto
[Codegen] [h] 000050 0000006f       j         0 -> 1005f
[Codegen] --------------------------------
[Codegen] [h]                  1003:
[Codegen]                                 # LIR=Integer
[Codegen] [h] 000054 00000293       mv        t0, zero
[Codegen]                                 # LIR=Goto
[Codegen] --------------------------------
[Codegen] [h]                  1005:

Comment 5

[André Bargull [:anba]]

Attachment: Bug 2049942 - Part 5: Remove ifdef JS_DISASM_RISCV64 around disassembleInstr. r=jandem!

Part 4 changed disassembleInstr() to be a no-op when JS_DISASM_RISCV64 is not defined.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/98706c9f348b
https://hg.mozilla.org/integration/autoland/rev/6f8e3289af47
Part 1: Don't pass implicit zero offset. r=jandem
https://github.com/mozilla-firefox/firefox/commit/1929c9ab74c7
https://hg.mozilla.org/integration/autoland/rev/2cd8489559a2
Part 2: Pass LabelDoc to branch methods. r=jandem
https://github.com/mozilla-firefox/firefox/commit/75bd89fe3f3e
https://hg.mozilla.org/integration/autoland/rev/d9b2cd62048f
Part 3: Remove some codegen jitspew calls. r=jandem
https://github.com/mozilla-firefox/firefox/commit/ac1725f857fb
https://hg.mozilla.org/integration/autoland/rev/b56146915772
Part 4: Use DisassemblerSpew for riscv64. r=jandem
https://github.com/mozilla-firefox/firefox/commit/8fd4d2e75f4e
https://hg.mozilla.org/integration/autoland/rev/535dfb12340a
Part 5: Remove ifdef JS_DISASM_RISCV64 around disassembleInstr. r=jandem

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6f8e3289af47
https://hg.mozilla.org/mozilla-central/rev/2cd8489559a2
https://hg.mozilla.org/mozilla-central/rev/d9b2cd62048f
https://hg.mozilla.org/mozilla-central/rev/b56146915772
https://hg.mozilla.org/mozilla-central/rev/535dfb12340a