2049948 - "Built-in VPN" menu item is shifted too far right when the device is rotated horizontally

Status: RESOLVED FIXED

(Firefox for Android :: Privacy, defect)

Description

[Alexandra Martin [:alemartin], FxA/SubPlat/VPN QA]

Attachment: video_beta_14.mp4

Prerequisites

• Firefox Beta is installed;
• Device IP/Locale is in a supported region where the VPN feature is active (e.g., United States).

Steps to reproduce

1. Open Settings > Privacy and security.
2. Rotate the phone to landscape mode and observe the screen.

Expected behavior

All list items align flush along the same left margin.

Actual behavior

The "Built-in VPN" item breaks grid alignment and indents further to the right than surrounding items.

Device information

• Firefox version: 153.0b3 (Build #2016168431)
• Android device model: Google Pixel 7a
• Android OS version: 16

Any additional information?

• See attached media;

Comment 1

[:Gela]

Attachment: Bug 2049948 - Fix Built-in VPN padding in horizontal mode in the Settings menu

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/df8313a4a7de
https://hg.mozilla.org/integration/autoland/rev/3a9a02b7ca4c
Fix Built-in VPN padding in horizontal mode in the Settings menu r=android-reviewers,mavduevskiy

Comment 3

[:Gela]

Attachment: Bug 2049948 - Fix Built-in VPN padding in horizontal mode in the Settings menu

{F73472669}

{F73472683}

Original Revision: https://phabricator.services.mozilla.com/D308594

Comment 4

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Small harmless change but without it if users use their device in landscape mode the menu item for VPN is going to have the wrong padding and stick further right than the rest.
• Code covered by automated testing?: no
• Fix verified in Nightly?: no
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing: Just a small UI update which was tested manually.
• Risk associated with taking this patch: low
• Explanation of risk level: Changing padding on a small item.
• String changes made/needed?: no
• Is Android affected?: yes

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3a9a02b7ca4c

Comment 6

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/128aae0c59d0
https://hg.mozilla.org/releases/mozilla-beta/rev/15340c3dd7c9