2050245 - Update buttons in Nova native-theme mode

Status: VERIFIED FIXED

(Toolkit :: Themes, defect, P3)

Description

[Mark Striemer [:mstriemer]]

In bug 2045752 I originally made the native-theme default buttons look like the neutral/old version due to issues with overriding the nativeTheme but this actually regressed the native-theme=false version so it's being undone in bug 2049847

Bug 2031765 added support for more overriding of the Nova values, and bug 2049439 is also on file to formalize this into the tokens file directly. One of those should help update the tokens.

We don't have any mocks for what the native-theme should look like. We could just make it behave like native-theme=false but using the OS accent colour

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: current-native-theme.png

Comment 2

[Jon Oliver]

Attachment: Bug 2050245 - update buttons in Nova native-theme mode r=#desktop-theme-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/433eada826fd
https://hg.mozilla.org/integration/autoland/rev/f7ab84af28eb
update buttons in Nova native-theme mode r=desktop-theme-reviewers,hjones,fchasen

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f7ab84af28eb

Comment 5

[Timea Zsoldos [:tzsoldos], Desktop QA]

I've reproduced this issue using Firefox 155.0a1 (2026.07.27) on Ubuntu 24.
Verified as fixed on the latest Nightly 158.0a1 (2026.09.14) and on Firefox 157.0b1, using Ubuntu 24, macOS 13 where the issue no longer persists.