2050256 - [Nova] Menus(List all tabs/Overflow/Application menu) don't have border in Default Light Theme

Status: RESOLVED WONTFIX

(Firefox :: Theme, defect, P2)

Description

[Brindusa Tot, DTE]

Attachment: MenuBorders.png

Found in

• Nightly 154.0a1

Affected versions

• Affected platforms: Windows 11, Ubuntu 26, macOS 13 ARM

Preconditions

• the browser.nova.enabled pref is set to "true"

Steps to reproduce

1. Open few tabs, make sure to use Light Theme
2. Open the List all Tabs menu
3. Observe the List all Tabs menu style

Expected result

• In Light Theme, the List all tabs should have a light gray border and no shadow.

Actual result

• In Light Theme, the List all tabs does not have border and it has a gray shadow.

Regression range

• No regrssion

Additional notes

• This is reproducible for other menus like Application menu or Overflow menu.

Comment 1

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:hjones, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Brindusa Tot, DTE]

This is reproducible for different group specific dialog menus, like: Create Tab Group dialog and Manage tab group panel.

Comment 3

[Michael Hynson]

Attachment: Bug 2050256 - Update panel border to use `--border-color-deemphasized`

Comment 4

[Michael Hynson]

The spec that I'm seeing contains a box shadow (--box-shadow-level-3), although the expected result says to have no shadow. Could you give guidance on the correct value please?

Comment 5

[Michael Hynson]

An added note on the box shadow - I see that there are some macOS specific styles to use the OS's box shadow. Also box shadows are in place for Proton on panels - so it seems like they should be there. For the time being, I'll move the patch to review to fix the border color for Light theme. If needed, we can file a separate bug for any adjustments to the box shadow.

Comment 6

[Michael Hynson]

After talking with :hjones and :sthompson, who pointed me to the spec for the panel itself, I think we should leave the border implementation in place. The implementation is using the --popup-border-color token which is also what the panel spec is using.

Also re: box shadow - the panel spec is using --box-shadow-level-3 like in the All Tabs panel spec.

Comment 7

[Michael Hynson]

Attachment: Bug 2050256 - Update --panel-box-shadow to use --box-shadow-level-3 per Nova Figma spec for panels

Comment 8

[Michael Hynson]

Spoke with Juliana and confirmed we should be using the box-shadow level 3 token. Patch submitted for review

Comment 9

[Michael Hynson]

The changes needed to set the panel box shadow to the level 3 box shadow token is affecting a larger footprint than expected. Both Dao's and Anna's reviews reflect the need to add/update more tokens. After discussing with Jules (along with consensus from Jane Wolf), considering we are close to the Nova launch, the change to update the panel's box shadow would be best handled post launch. The current state of the panel's box shadow should be ok.

Comment 10

[Stephen Thompson [:sthompson]]

Reflecting the decision not to fix this by 157.

Comment 11

[Michael Hynson]

Per this thread, closing as WONTFIX since there are no intentions to match the current Figma