2050307 - Stop minifying the Focus instrumented-test APKs

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Ryan VanderMeulen [:RyanVM]]

focus-android-test-nightly and focus-android-test-beta in taskcluster/kinds/build-apk/kind.yml are missing disable-optimization: true, which every Fenix android-test job and every *-firebase job already sets. These jobs build a signed androidTest APK for Firebase (the build type only controls the signing key); they are not meant to exercise minification.

Because of that, the Focus nightly/beta androidTest APKs are R8-processed. Under AGP 8's lenient R8, the resulting missing-class references (optional LeakCanary integrations pulled in transitively) are tolerated as warnings, but AGP 9's default R8 full mode makes them fatal, breaking the build.

We should add disable-optimization: true to both jobs so they match the Fenix jobs and skip minification. This corrects a pre-existing Focus/Fenix inconsistency and is backwards-compatible with AGP 8.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 2050307 - Stop minifying the Focus instrumented-test APKs r?#android-reviewers

The focus-android-test-nightly and focus-android-test-beta jobs build a signed androidTest APK for
Firebase, which requires the test APK and the app under test to share a signing key (hence the
nightly/beta build type). These APKs are not meant to exercise minification, but unlike the
equivalent Fenix jobs - and unlike every *-firebase job - they were missing disable-optimization,
so R8 ran on the test APK. Add disable-optimization to match, assembling the test APKs without
shrinking.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a63a84248f13
https://hg.mozilla.org/integration/autoland/rev/fc9c98ddd60e
Stop minifying the Focus instrumented-test APKs r=android-reviewers,jonalmeida

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/fc9c98ddd60e