2050562 - macOS 10.15 tests being scheduled on every push to Beta

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, defect, P1)

Description

[Ryan VanderMeulen [:RyanVM]]

I noticed this today. They seem to not be getting optimized out like all other tests. I didn't see this during the 152 cycle, so maybe something broke with 153.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 2043540

:rcurran, since you are the author of the regressor, bug 2043540, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Julien Cristau [:jcristau]]

Attachment: Bug 2050562 - suppress macosx1015 mochitest-browser-chrome on beta. r?#taskgraph-reviewers

Add a "test-backstop" strategy (aliases skip-unless-backstop by default)
and override it to "always" in the beta project overrides, alongside the
existing "test" override. Update the apply_bug2043540_optimization transform
to use "test-backstop" instead of "skip-unless-backstop" directly, so that
the beta override correctly suppresses these tasks on every push.

On beta backstop=True on every push, so using skip-unless-backstop directly
caused macOS 10.15 mochitest-browser-chrome tasks to run on every push.

Comment 3

[Julien Cristau [:jcristau]]

Attachment: Bug 2050562 - suppress macosx1015 mochitest-browser-chrome on beta.

Add a "test-backstop" strategy (aliases skip-unless-backstop by default)
and override it to "always" in the beta project overrides, alongside the
existing "test" override. Update the apply_bug2043540_optimization transform
to use "test-backstop" instead of "skip-unless-backstop" directly, so that
the beta override correctly suppresses these tasks on every push.

On beta backstop=True on every push, so using skip-unless-backstop directly
caused macOS 10.15 mochitest-browser-chrome tasks to run on every push.

Original Revision: https://phabricator.services.mozilla.com/D308844

Comment 4

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: extra load on mac testers
• Code covered by automated testing?: no
• Fix verified in Nightly?: no
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing: n/a
• Risk associated with taking this patch: low
• Explanation of risk level: CI task scheduling fix
• String changes made/needed?: n/a
• Is Android affected?: no

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0a610dad9b34
https://hg.mozilla.org/integration/autoland/rev/edf66ab2582a
suppress macosx1015 mochitest-browser-chrome on beta. r=taskgraph-reviewers,bhearsum

Comment 6

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/8c8aeab9422b
https://hg.mozilla.org/releases/mozilla-beta/rev/bfdaf0b727a1

Comment 7

[amarc]

https://hg.mozilla.org/mozilla-central/rev/edf66ab2582a