Closed Bug 2050614 Opened 4 months ago Closed 3 months ago

[wpt-sync] Sync PR 60905 - [iframe] Re-Fix yet another flaky case

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
155 Branch
Tracking Status
firefox155 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 60905 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/60905
Details from upstream follow.

Koji Ishii <kojii@chromium.org> wrote:

[iframe] Re-Fix yet another flaky case

It turned out that the last effort to fix "yet another flaky
case" in crrev.com/c/8001110 incorrectly used assert_equals
when comparing arrays. That made the flakiness worse. This
patch fixes it to use assert_array_equals instead.

Ran the test 100 times locally and observed no flakes.

Bug: 525685238, 418397278
Change-Id: Id0c0747b436a22956bb2c48fb020a1730f193fc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8001131
Commit-Queue: Ian Kilpatrick &lt;ikilpatrick@chromium.org>
Reviewed-by: Ian Kilpatrick &lt;ikilpatrick@chromium.org>
Auto-Submit: Koji Ishii &lt;kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1652488}

PR 60905 applied with additional changes from upstream: c57b9f6342cb924d1eb0dd6f7291d7cc21f5f65f

Component: web-platform-tests → Layout
Product: Testing → Core
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---

CI Results

Ran 8 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 29 tests and 1 subtests

Status Summary

Firefox

OK : 1[GitHub] 14[Gecko-linux2404-64-opt] 15[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS : 1[Gecko-windows11-32-25h2-debug] 9[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL : 2[GitHub] 23[Gecko-windows11-32-25h2-debug] 28[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
TIMEOUT: 1
ERROR : 1[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt, GitHub] 2[Gecko-linux2404-64-opt]

Chrome

PASS : 1
TIMEOUT: 1
ERROR : 2

Safari

OK : 2
FAIL : 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Status: REOPENED → RESOLVED
Closed: 4 months ago → 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 155 Branch
You need to log in before you can comment on or make changes to this bug.