2050698 - [wpt-sync] Sync PR 60914 - [Masonry] Don't inherit line names into auto-placed subgrids

Status: RESOLVED FIXED

(Core :: Layout: Grid, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 60914 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/60914
Details from upstream follow.

Alison Maher <[e-mail]> wrote:

[Masonry] Don't inherit line names into auto-placed subgrids

Per CSS Grid Level 3 [1], a subgrid that is auto-placed within a grid
lanes container must not inherit line names or named areas from that
container: its position in the grid axis is unknown at line-name
resolution time, so there is no valid mapping from the container's lines
to the subgrid's.

This applies only between an auto-placed subgrid and its direct grid
lanes parent. Nested subgrids still inherit line names from their own
subgrid parent, but none inherit the grid lanes container's lines.

[1] https://drafts.csswg.org/css-grid-3/#subgrids

Bug: 343257585
Change-Id: Ic19e18d1b743a9c35f1afa7a0faddd3783ef3fc7
Reviewed-on: https://chromium-review.googlesource.com/7997264
WPT-Export-Revision: 3054067ee2f6bcfc3e6038ae8d095da6372ea8e4

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 60914 applied with additional changes from upstream: 25a20192274205f33cf7910dc7b925dd83f6c51d

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=41755e7d2bca68ec11e2ad5407099936957d1d90

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests

Status Summary

Firefox

PASS: 1
FAIL: 5

Chrome

PASS: 2
FAIL: 4

Safari

PASS: 5
FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

• /css/css-grid/grid-lanes/subgrid/grid-subgridded-to-grid-lanes/line-names/column-line-names-005.html [wpt.fyi]: FAIL

New Tests That Don't Pass

• /css/css-grid/grid-lanes/subgrid/grid-subgridded-to-grid-lanes/line-names/column-line-names-005.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: PASS)
• /css/css-grid/grid-lanes/subgrid/grid-subgridded-to-grid-lanes/line-names/column-line-names-016.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: PASS)
• /css/css-grid/grid-lanes/subgrid/grid-subgridded-to-grid-lanes/line-names/column-line-names-017.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: PASS)
• /css/css-grid/grid-lanes/subgrid/grid-subgridded-to-grid-lanes/line-names/row-line-names-005.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: FAIL)
• /css/css-grid/grid-lanes/subgrid/grid-subgridded-to-grid-lanes/line-names/row-line-names-016.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: PASS)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4b2593862e10
https://hg.mozilla.org/integration/autoland/rev/a3c1efaccd89
[wpt PR 60914] - [Masonry] Don't inherit line names into auto-placed subgrids, a=testonly
https://github.com/mozilla-firefox/firefox/commit/6cbab40e123b
https://hg.mozilla.org/integration/autoland/rev/c8fc3c1b076c
[wpt PR 60914] - Update wpt metadata, a=testonly

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/a3c1efaccd89
https://hg.mozilla.org/mozilla-central/rev/c8fc3c1b076c