2050750 - Redesigned ETP Custom UI no longer records privacy.ui.fpp.click telemetry for the suspect-fingerprinting controls

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[Emma Zühlcke [:emz]]

With the settings redesign enabled (browser.settings-redesign.enabled), interacting with the Suspect Fingerprinting checkbox and scope menu in the ETP Custom UI no longer records the privacy.ui.fpp.click Glean telemetry.

In the legacy UI, browser/components/preferences/privacy.js records Glean events on these controls: Glean.privacyUiFpp.click.checkbox.record({ checked }) on the fingerprinting protection checkbox and Glean.privacyUiFpp.click.menu.record({ value }) on the menulist (wired in initContentBlocking()).

In the redesign (browser/components/preferences/config/privacy.mjs), the etpCustomSuspectFingerprintingProtectionEnabled and etpCustomSuspectFingerprintingProtectionEnabledContext settings flip privacy.fingerprintingProtection / privacy.fingerprintingProtection.pbmode but have no onUserChange handler and record no telemetry. The probe (privacy.ui.fpp.click, defined in browser/components/preferences/metrics.yaml, expires: never) is therefore no longer collected from the redesigned UI.

Fix: add onUserChange handlers to these settings recording Glean.privacyUiFpp.click.checkbox / .menu to match legacy. May warrant a data-review ping since it restores collection from the new UI path.

Found while auditing legacy-vs-redesign ETP Custom toggle behavior for bug 2050000.

Comment 1

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 2028609

Comment 2

[Emma Zühlcke [:emz]]

Attachment: Bug 2050750 - Record privacy.ui.fpp.click telemetry from the redesigned ETP Custom suspect fingerprinting controls. r=#anti-tracking!

The legacy ETP Custom UI records the privacy.ui.fpp.click Glean events when
the user interacts with the suspect fingerprinting checkbox and scope menu.
The settings redesign reimplemented these controls but recorded no telemetry,
so the probe (which never expires) stopped being collected from the new UI.

Record Glean.privacyUiFppClick.checkbox / .menu from the onUserChange handlers
of the etpCustomSuspectFingerprintingProtectionEnabled and
etpCustomSuspectFingerprintingProtectionEnabledContext settings, mirroring the
old design's instrumentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7c785f864168
https://hg.mozilla.org/integration/autoland/rev/1cba0ed37886
Record privacy.ui.fpp.click telemetry from the redesigned ETP Custom suspect fingerprinting controls. r=bvandersloot,mstriemer

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/1cba0ed37886

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Given that 153 is our next ESR release, I'm thinking we probably want to get this uplifted to Beta.

Comment 6

[Emma Zühlcke [:emz]]

Request submitted.

Comment 7

[Emma Zühlcke [:emz]]

Hmm in that case would you also like uplifts for the other ETP custom settings bugs? That's Bug 2050000 and Bug 2050749. Given their severity I had not considered them for an uplift prior.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Probably a good idea, yeah.

Comment 9

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: 1. Missing fingerprinting protection settings telemetry (no direct user impact)

2. Outdated tracker lists right after enabling cryptomining / fingerprinting protections via ETP custom. This will result in a delay until the protection kicks in.
3. Social media tracker blocking feature not controllable via ETP custom.

• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: Bug 2050000: See bug description (comment 0)

Bug 2050749, Bug 2050749 are sufficiently covered by automated tests and don't need manual testing.

• Risk associated with taking this patch: low
• Explanation of risk level: Fairly small code changes only affecting the ETP custom subpanel. Good automated test coverage.
• String changes made/needed?: no
• Is Android affected?: no

Comment 10

[Emma Zühlcke [:emz]]

Attachment: Bug 2050750 - Record privacy.ui.fpp.click telemetry from the redesigned ETP Custom suspect fingerprinting controls.

The legacy ETP Custom UI records the privacy.ui.fpp.click Glean events when
the user interacts with the suspect fingerprinting checkbox and scope menu.
The settings redesign reimplemented these controls but recorded no telemetry,
so the probe (which never expires) stopped being collected from the new UI.

Record Glean.privacyUiFppClick.checkbox / .menu from the onUserChange handlers
of the etpCustomSuspectFingerprintingProtectionEnabled and
etpCustomSuspectFingerprintingProtectionEnabledContext settings, mirroring the
old design's instrumentation.

Original Revision: https://phabricator.services.mozilla.com/D308995

Comment 11

[Emma Zühlcke [:emz]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #8)

Probably a good idea, yeah.

Ok I've requested an uplift covering the other bugs. The patches landed as a stack in Nightly so uplifting them together is easiest. The base patch has already been uplifted.

Comment 12

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/162ca81359f1
https://hg.mozilla.org/releases/mozilla-beta/rev/d94b65ff67c7

Comment 13

[Adrian Florinescu [:aflorinescu]]

Reproduced the issue of glean telemetry not being recorded for Suspected fingerprinters with affected Nightly 154.0a1 (2026-07-04) then verified it fixed with Nightly 154.0a1 (2026-07-10) on Windows 11, Mac 13 and Ubuntu 24.

STR:

1. Open about:preferences#etpCustomize
2. Find Suspected fingerprinters checkbox and flip it off/on
3. In a new tab open about:glean + F12 / console
4. In the console input Glean.privacyUiFppClick.checkbox.testGetValue()

ER:
There should be two arrays recorded, on for the checkbox false and one for the checkbox true

Comment 14

[Monica Chiorean]

Verified as fixed using steps from comment #13 on Windows 11x64 / Mac 15.5 and Firefox build 153.0b11.