Closed
Bug 2050787
Opened 4 months ago
Closed 4 months ago
Clean-up various issues in Architecture-riscv64.h
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
154 Branch
| Tracking | Status | |
|---|---|---|
| firefox154 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
References
(Blocks 1 open bug)
Details
Attachments
(4 external files)
No description provided.
| Assignee | ||
Comment 1•4 months ago
|
||
Remove invalid_reg so that comments match the code and the register encoding
doesn't need an additional bit to represent the invalid register.
| Assignee | ||
Comment 2•4 months ago
|
||
| Assignee | ||
Comment 3•4 months ago
|
||
These comments were apparently copied from "Architecture-none.h".
| Assignee | ||
Comment 4•4 months ago
|
||
Slim down FloatRegister so that testing the encoding and type can be
directly performed using bitwise immediate instructions.
For example Clang compiled if (freg.isSingle()) { ... } to:
li a1, 255
slli a1, a1, 32
and a0, a0, a1
li a1, 1
slli a1, a1, 32
bne a0, a1, .L
...
.L:
And now it's just:
andi a0, a0, 96
li a1, 32
bne a0, a1, .L
...
.L:
Pushed by andre.bargull@gmail.com:
https://github.com/mozilla-firefox/firefox/commit/a7d690fb0ee8
https://hg.mozilla.org/integration/autoland/rev/2091eeccd0d4
Part 1: Remove invalid_reg for Register/FloatRegister. r=spidermonkey-reviewers,jandem
https://github.com/mozilla-firefox/firefox/commit/e1f6e527f92d
https://hg.mozilla.org/integration/autoland/rev/07452070d33a
Part 2: Modernise code to use 'using' instead of 'typedef'. r=spidermonkey-reviewers,jandem
https://github.com/mozilla-firefox/firefox/commit/ab043d98751b
https://hg.mozilla.org/integration/autoland/rev/0ba3e2d28cb4
Part 3: Remove comments which don't apply to riscv64. r=spidermonkey-reviewers,jandem
https://github.com/mozilla-firefox/firefox/commit/2c0d8e12c13d
https://hg.mozilla.org/integration/autoland/rev/f9858af6a689
Part 4: Slim down FloatRegister for riscv64. r=spidermonkey-reviewers,jandem
Comment 6•4 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2091eeccd0d4
https://hg.mozilla.org/mozilla-central/rev/07452070d33a
https://hg.mozilla.org/mozilla-central/rev/0ba3e2d28cb4
https://hg.mozilla.org/mozilla-central/rev/f9858af6a689
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
status-firefox154:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
Updated•3 months ago
|
QA Whiteboard: [qa-triage-done-c155/b154]
You need to log in
before you can comment on or make changes to this bug.
Description
•