205083 - Composer's Selection List Properties dialog appears with a XML parsing error

Status: VERIFIED FIXED

(SeaMonkey :: Composer, defect)

Description

[Chris Petersen]

Build: 2003-05-07-03
Platform: All
Expected Results: Selection List Properties Dialog should appear with correct
content
What I got: XML parser error (undefined entity)

Location: chrome://editor/content/EdSelectProps.xul
Line Number 78, Column 83: 

<label control="SelectName" value="&SelectName.label;"
accesskey="&SelectName.accesskey;" />



Steps to reproduce:

1) Open the attached test case which contains the select element in Composer
2) Place focus on the select element 
3) Choose Selection List Properties from the Format menu.
4) Notice XML parser in dialog.

Comment 1

[Chris Petersen]

Attachment: Select element

Comment 2

[Chris Petersen]

Looks like this has been broken on the trunk for months. The oldest trunk build
on  windows I can locate is 2003-02-02-04. The problem is occuring in this build
so I'm not able to track the regression any further.

Comment 3

[Kathleen :Brade]

-->jag

Comment 4

[Samir Gehani]

adt: nsbeta1+/adt1

Comment 5

[[e-mail]]

This broke on 05 Oct 2002 13:44 when cmanske checked in some fixes for me.
The rest of the fixes are in the patch in bug 45495.

Comment 6

[Kathleen :Brade]

Neil--we really don't want to ship 1.4 with this regression; is there anyway we
can remove the dependency on bug 45495?  Can you split up the patch enough to
address this specific issue?

Comment 7

[[e-mail]]

Attachment: Just the access key changes

This is attachment 109104 [details] [diff] [review] but with all the code changes removed.
/me wonders if alecf's sr= still applies...

Comment 8

[jag (Peter Annema)]

Comment on attachment 123274 [details] [diff] [review]
Just the access key changes

r=jag. Let's find out if sr=alecf applies :-)

Comment 9

[Alec Flett]

Comment on attachment 123274 [details] [diff] [review]
Just the access key changes

sr=alecf

Comment 10

[[e-mail]]

Comment on attachment 123274 [details] [diff] [review]
Just the access key changes

This low risk patch fixes some localization issues in editor form element
dialogs.

Comment 11

[(not reading, please use [e-mail] instead)]

we're past a l10n freeze for 1.4.

This is the minimal patch needed to fix the XML error?

jag, to reduce perceived risk, and get l10n approval, can you come up with a
minimal patch, one that just defines the missing accesskey?

(or, if we get rejected due to l10n changes, we could also remove
accesskey="&SelectName.accesskey;" for 1.4 final.  and then, for 1.5, land the
entire patch, with all the new accesskeys)

also, looking at the patch:

 <!ENTITY EditLegendText.label "Edit Legend:">
+<!ENTITY EditLegendText.accesskey "T">

shouldn't that be "t", instead of "T"?

Comment 12

[(not reading, please use [e-mail] instead)]

Comment on attachment 123274 [details] [diff] [review]
Just the access key changes

this seems right for 1.5, can we get a minimal patch for 1.4 final?

Comment 13

[[e-mail]]

Attachment: Patch for branch only

If previous patch can't go on the trunk, this might work for the branch,
although I haven't tested it.

Comment 14

[jag (Peter Annema)]

Tested, works fine.

Comment 15

[(not reading, please use [e-mail] instead)]

Comment on attachment 123890 [details] [diff] [review]
Patch for branch only

sorry for the delay, sr/a=sspitzer

thanks neil (and jag)

I'll let you guys decide to open a new bug or not, for 1.5

Comment 16

[jag (Peter Annema)]

Comment on attachment 123890 [details] [diff] [review]
Patch for branch only

I've just checked in this patch. Once 1.5 opens this can be backed out and
replaced by the previous patch that does the better thing.

Comment 17

[jag (Peter Annema)]

Removing keywords to get this off the radar.

Comment 18

[[e-mail]]

Previous patch checked in as part of bug 45495.

Comment 19

[Chris Petersen]

Verified on the Macho (2003-05-29-08) and win32 (2003-05-27-08) trunk builds.