Tidy-up MoveEmitter a bit
Categories
(Core :: JavaScript Engine: JIT, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox154 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(6 external files)
Changes:
- Make setScratchRegister x86 specific, because it's only called from within
#ifdef JS_CODEGEN_X86guarded code. - Make destructor and
assertDonemore consistent across architectures. - Make internal methods
private. - Make
getAdjusted{Offset,Address}const. - Remove unused
spilledFloatReg_members. - Remove unused 'from' parameter from
breakCycle. - ...
| Assignee | ||
Comment 1•4 months ago
|
||
setScratchRegister is only called from within #ifdef JS_CODEGEN_X86 guarded
code, so it isn't necessary to define it for other architectures than x86.
| Assignee | ||
Comment 2•4 months ago
|
||
Using out-of-line definitions just for an assertion doesn't seem helpful, so
move the definitions for all architectures into the header files, just like
it's already the case for ARM64.
| Assignee | ||
Comment 3•4 months ago
|
||
| Assignee | ||
Comment 4•4 months ago
|
||
Use const methods to match other const methods in MoveEmitter.
| Assignee | ||
Comment 5•4 months ago
|
||
Remove the unused spilledFloatReg_ and use fields initialisers. Also
update comments to reflect the current code.
For loong64 and mips additionally remove unused fields and the subslot
parameter from cycleSlot, which is always zero. And for mips-only,
rename spilledReg_ to tempReg_, because no spilling takes place.
| Assignee | ||
Comment 6•4 months ago
|
||
Comment 8•4 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/74a10ac026b9
https://hg.mozilla.org/mozilla-central/rev/f4b1be6a3ed8
https://hg.mozilla.org/mozilla-central/rev/ad2f4d0fd307
https://hg.mozilla.org/mozilla-central/rev/f254215fc5e6
https://hg.mozilla.org/mozilla-central/rev/1a25ae866bf0
https://hg.mozilla.org/mozilla-central/rev/0c7ffe844e53
Updated•3 months ago
|
Description
•