Closed
Bug 2050954
Opened 1 month ago
Closed 6 days ago
Add logic to show different tip messages through out the day/week
Categories
(Firefox :: New Tab Page, enhancement)
Firefox
New Tab Page
Tracking
()
RESOLVED
FIXED
155 Branch
| Tracking | Status | |
|---|---|---|
| firefox155 | --- | fixed |
People
(Reporter: maxx, Assigned: maxx)
References
(Blocks 1 open bug)
Details
Attachments
(3 files, 1 obsolete file)
No description provided.
| Assignee | ||
Comment 1•1 month ago
|
||
Replaces the Privacy widget's hardwired tip with logic that picks which secondary message (or a blank) to show on each new tab.
- New lib/Widgets/PrivacyMessages.sys.mjs: a provisional message catalog plus a pure selectPrivacyMessage() encoding the precedence ladder, milestone tiers, frequency caps, blank chance, and promo limits. The full business rules are documented at the top of the file.
- PrivacyFeed gathers week/month/year/all-time totals and the day streak from TrackingDBService, best-effort feature-usage flags (sign-in, logins, Relay masks), and profile age, runs the selector on NEW_TAB_INIT, and persists scheduler state in a skipBroadcast pref. The live count still refreshes on SYSTEM_TICK. Aggregation is feed-side, so the change stays trainhoppable with no platform edits.
- Privacy.jsx renders purely from the broadcast: empty / count-block (blank, streak) / tip layouts, a per-message icon map, and temp-text-vs-Fluent.
- Adds widgets.privacy.blankChance (trainhop-overridable, default 0.4) and the internal widgets.privacy.messageState pref; resolvePrivacyMaxCount moves to WidgetsRegistry so the parent feed can share it.
| Assignee | ||
Comment 2•1 month ago
|
||
Updated•1 month ago
|
Attachment #9603033 -
Attachment description: WIP: Bug 2050954 - Add message scheduling logic to the Privacy New Tab widget → WIP: Bug 2050954 - (Part 1) Add message scheduling logic to the Privacy New Tab widget
Updated•1 month ago
|
Attachment #9603228 -
Attachment description: WIP: Bug 2050954 - Adopt the Phase 1 Fluent message ids in the Privacy widget catalog r?#home-newtab-reviewers → Bug 2050954 - (Part 2) Adopt the Phase 1 Fluent message ids in the Privacy widget catalog r?#home-newtab-reviewers
| Assignee | ||
Comment 3•1 month ago
|
||
Updated•1 month ago
|
Attachment #9603033 -
Attachment description: WIP: Bug 2050954 - (Part 1) Add message scheduling logic to the Privacy New Tab widget → Bug 2050954 - (Part 1) Add message scheduling logic to the Privacy New Tab widget r?#home-newtab-reviewers
Updated•1 month ago
|
Attachment #9606012 -
Attachment description: Bug 2050954 - (Part 3) Gate Privacy widget VPN promo messages behind a pref + trainhopConfig r?#home-newtab-reviewers → Bug 2050954 - (Part 2) Gate Privacy widget VPN promo messages behind a pref + trainhopConfig r?#home-newtab-reviewers
Updated•1 month ago
|
Attachment #9603228 -
Attachment is obsolete: true
Updated•24 days ago
|
Attachment #9603033 -
Attachment description: Bug 2050954 - (Part 1) Add message scheduling logic to the Privacy New Tab widget r?#home-newtab-reviewers → WIP: Bug 2050954 - (Part 1) Add message scheduling logic to the Privacy New Tab widget r?#home-newtab-reviewers
Updated•24 days ago
|
Attachment #9606012 -
Attachment description: Bug 2050954 - (Part 2) Gate Privacy widget VPN promo messages behind a pref + trainhopConfig r?#home-newtab-reviewers → WIP: Bug 2050954 - (Part 2) Gate Privacy widget VPN promo messages behind a pref + trainhopConfig r?#home-newtab-reviewers
| Assignee | ||
Comment 4•24 days ago
|
||
Updated•8 days ago
|
Attachment #9603033 -
Attachment description: WIP: Bug 2050954 - (Part 1) Add message scheduling logic to the Privacy New Tab widget r?#home-newtab-reviewers → Bug 2050954 - (Part 1) Add message scheduling logic to the Privacy New Tab widget r?#home-newtab-reviewers
Updated•8 days ago
|
Attachment #9606012 -
Attachment description: WIP: Bug 2050954 - (Part 2) Gate Privacy widget VPN promo messages behind a pref + trainhopConfig r?#home-newtab-reviewers → Bug 2050954 - (Part 2) Gate Privacy widget VPN promo messages behind a pref + trainhopConfig r?#home-newtab-reviewers
Updated•8 days ago
|
Attachment #9613947 -
Attachment description: WIP: Bug 2050954 - (Part 3) Add forceMessageId debug pref for the Privacy widget r?#home-newtab-reviewers → Bug 2050954 - (Part 3) Add forceMessageId debug pref for the Privacy widget r?#home-newtab-reviewers
Pushed by mcrawford@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/64ae29810ebe
https://hg.mozilla.org/integration/autoland/rev/7f48351f9533
(Part 1) Add message scheduling logic to the Privacy New Tab widget r=Dre
https://github.com/mozilla-firefox/firefox/commit/e842b22bb664
https://hg.mozilla.org/integration/autoland/rev/8a6faed89569
(Part 2) Gate Privacy widget VPN promo messages behind a pref + trainhopConfig r=Dre
https://github.com/mozilla-firefox/firefox/commit/5147a02cd60c
https://hg.mozilla.org/integration/autoland/rev/7ef001eee9ac
(Part 3) Add forceMessageId debug pref for the Privacy widget r=reemhamz
Comment 6•6 days ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7f48351f9533
https://hg.mozilla.org/mozilla-central/rev/8a6faed89569
https://hg.mozilla.org/mozilla-central/rev/7ef001eee9ac
Status: NEW → RESOLVED
Closed: 6 days ago
status-firefox155:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 155 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•