2050972 - Add ability to dimiss current daily photo

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement)

Description

[Maxx Crawford [:maxx]]

Requirements:

• There should be a context menu item "Don't like today's photo" text.
• When clicked, the current image is hidden and replaced with a random existing Wallpaper image

Figma comment: https://www.figma.com/design/i8wWurQ8yn9y5hCjnf8BYu?node-id=2254-16727#1705326776

Comment 1

[dgrant]

Attachment: Bug 2050972 - Picture of the Day: let people hide today's picture until the next day. r?#home-newtab-reviewers

Behavior: the context menu's "Hide today's picture" now dismisses the current
picture (the widget falls back to the empty state), and the menu shows "Show
today's picture" while dismissed (as does the empty-state eye button).
Dismissal is keyed to the picture's published date and stored in the
widgets.pictureOfTheDay.dismissedDate pref, so the next day's picture appears
again automatically.

Risk: content plus one pref; no feed or metrics.yaml change. State is a pref,
so it survives reload.

Validation: ./mach lint; newtab jest (PictureOfTheDay, incl. dismiss/restore).
Bundle/CSS regenerated at this commit.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9aac0df02223
https://hg.mozilla.org/integration/autoland/rev/d4894c562055
Picture of the Day: let people hide today's picture until the next day. r=Dre

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b61addce1d85
https://hg.mozilla.org/integration/autoland/rev/6d54818a37af
Revert "Bug 2050972 - Picture of the Day: let people hide today's picture until the next day. r=Dre"

Comment 4

[Cosmin Sabou [:CosminS]]

Backed out for causing node failures.

Push with failures

Failure log

Backout link

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a9efec62f694
https://hg.mozilla.org/integration/autoland/rev/72b12cbb1ce9
Picture of the Day: let people hide today's picture until the next day. r=Dre

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/72b12cbb1ce9