2051041 - Downloads being deleted when "Remove from download history" option selected

Status: VERIFIED FIXED

(Firefox for Android :: Downloads, defect)

Description

[jasonr9]

Steps to reproduce:

Save/download a file(s) in Firefox Android with Settings>Download Settings>Remove from download history button selected. Select a file(s) from Downloads and hit delete. File type or method inside Firefox doesn't seem to matter.

Actual results:

File(s) will be deleted from both history and device.

Expected results:

File(s) should have be deleted only from history.

Comment 1

[Titouan Thibaud [:titouan]]

Attachment: Bug 2051041 - Make sure a completed download is not deleted from disk when user settings is "delete downloads from history only".

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bd1ba0ec7ac5
https://hg.mozilla.org/integration/autoland/rev/2bef9416df5c
Make sure a completed download is not deleted from disk when user settings is "delete downloads from history only". r=android-reviewers,giorga

Comment 3

[Titouan Thibaud [:titouan]]

Attachment: Bug 2051041 - Make sure a completed download is not deleted from disk when user settings is "delete downloads from history only".

Original Revision: https://phabricator.services.mozilla.com/D309781

Comment 4

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: User who have their Download settings deletion behavior set to "Remove from history only" have their files removed from their disk.
  This can create data loss for some users.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: - Download a file
• Open the Downloads screen
• Open the Downloads settings and make sure "Remove from download history" is selected
• Go back to the Downloads screen and delete the last download
• Wait until the download snackbar goes away
• Open a files browser and make sure the downloaded file is still on the disk.
• Risk associated with taking this patch: medium
• Explanation of risk level: The patch has not backed in Nightly.
• String changes made/needed?: No
• Is Android affected?: yes

Comment 5

[Titouan Thibaud [:titouan]]

Attachment: Bug 2051041 - Make sure a completed download is not deleted from disk when user settings is "delete downloads from history only".

Original Revision: https://phabricator.services.mozilla.com/D309781

Comment 6

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: User who have their Download settings deletion behavior set to "Remove from history only" have their files removed from their disk.
  This can create data loss for some users.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: - Download a file
• Open the Downloads screen
• Open the Downloads settings and make sure "Remove from download history" is selected
• Go back to the Downloads screen and delete the last download
• Wait until the download snackbar goes away
• Open a files browser and make sure the downloaded file is still on the disk.
• Risk associated with taking this patch: medium
• Explanation of risk level: The patch has not backed in Nightly.
• String changes made/needed?: No
• Is Android affected?: yes

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/2bef9416df5c

Comment 9

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/7671017398a2
https://hg.mozilla.org/releases/mozilla-beta/rev/0aca7894d02f

Comment 10

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/486e9f276f92
https://hg.mozilla.org/releases/mozilla-release/rev/b1204e773b9d

Comment 11

[Mira Lobontiu (Android QA)]

Verified as fixed on Nightly 154.0a1, Beta 153.0b9, and 152.0.5 dot release, using a Xiaomi Poco X7 Pro (Android 16), and a Samsung Galaxy Z Fold 4 (Android 16).