2051359 - ui component for Source Citations for Exa Integration (v1)

Status: VERIFIED FIXED

(Core :: Machine Learning: Frontend, enhancement)

Description

[Ed Lee :Mardak]

Include source attribution in assistant responses that leverage Exa websearch in order to provide users with a more trustworthy and transparently grounded assistant experience.

https://www.figma.com/design/75Z1LtkCEUJWCxoY2KyNHv/Smart-Window-Q2?node-id=5627-172639

the citation explorations have designs for inline after each paragraph or at the end of the response, so we can build a ui component that renders 1 citation or more with a dropdown showing the list

we can use a followup bug to actually link the model output indicating the citation

Comment 1

[Ed Lee :Mardak]

sounds like the preferred design is inline citations after each paragraph as opposed to what we do for memories and aggregate to a menu at the bottom of the response. so there'll need to be some paragraph level aggregation (potentially citation mid paragraph or multiple at the end) to show the ui component

Comment 2

[Florian Zia [:flozia]]

Attachment: Bug 2051359 - Part 1: Add small size variant to ai-website-chip

Comment 3

[Florian Zia [:flozia]]

Attachment: Bug 2051359 - Part 2: Support custom child items in smartwindow-panel-list

Comment 4

[Florian Zia [:flozia]]

Attachment: Bug 2051359 - Part 3: Add citation component for assistant chat messages r=fluent-reviewers,czhou,bolsson

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/39b8b137c7c6
https://hg.mozilla.org/integration/autoland/rev/41b545b46163
Part 1: Add small size variant to ai-website-chip r=czhou
https://github.com/mozilla-firefox/firefox/commit/69639fa7bb77
https://hg.mozilla.org/integration/autoland/rev/67717fa1bfcc
Part 2: Support custom child items in smartwindow-panel-list r=czhou
https://github.com/mozilla-firefox/firefox/commit/1bd4d53e0071
https://hg.mozilla.org/integration/autoland/rev/ec6faa4337d3
Part 3: Add citation component for assistant chat messages r=fluent-reviewers,czhou,bolsson

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3cba2d0f2180
https://hg.mozilla.org/integration/autoland/rev/0d1b20400e35
Revert "Bug 2051359 - Part 3: Add citation component for assistant chat messages r=fluent-reviewers,czhou,bolsson" for causing bc failures at chat-assistant-citations.css

Comment 7

[Silaghi Andreea]

Backed out for causing bc failures at chat-assistant-citations.css
Backout Link
Push with failures
Failure Log
Failure line TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | checkAllTheFiles - file only referenced from unreferenced files: chrome://browser/content/aiwindow/components/chat-assistant-citations.css referenced from chrome://browser/content/aiwindow/components/chat-assistant-citations.mjs

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bcd7e9e1bc27
https://hg.mozilla.org/integration/autoland/rev/9510cc36c422
Part 1: Add small size variant to ai-website-chip r=czhou
https://github.com/mozilla-firefox/firefox/commit/9b71c8b95e3b
https://hg.mozilla.org/integration/autoland/rev/0a29bc51cbcc
Part 2: Support custom child items in smartwindow-panel-list r=czhou
https://github.com/mozilla-firefox/firefox/commit/d55cbab550bd
https://hg.mozilla.org/integration/autoland/rev/1111a36c3e65
Part 3: Add citation component for assistant chat messages r=fluent-reviewers,czhou,bolsson

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1d89fc93290c
https://hg.mozilla.org/integration/autoland/rev/8ca3de1be53f
Revert "Bug 2051359 - Part 3: Add citation component for assistant chat messages r=fluent-reviewers,czhou,bolsson" for causing bc failures @ chat-assistant-citations

Comment 10

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ chat-assistant-citations

Backout link: https://hg.mozilla.org/integration/autoland/rev/8ca3de1be53fb9099df46da2e4dbe82b52c79e85

Push with failures

Failures log -> TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | checkAllTheFiles - there should be no unreferenced files - Got 2, expected +0

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f96d2801139b
https://hg.mozilla.org/integration/autoland/rev/d81d3e34776a
Part 1: Add small size variant to ai-website-chip r=czhou
https://github.com/mozilla-firefox/firefox/commit/9fa2532b38cd
https://hg.mozilla.org/integration/autoland/rev/9c6c5a89c5de
Part 2: Support custom child items in smartwindow-panel-list r=czhou
https://github.com/mozilla-firefox/firefox/commit/60533c0bf285
https://hg.mozilla.org/integration/autoland/rev/8e40d12c576d
Part 3: Add citation component for assistant chat messages r=fluent-reviewers,czhou,bolsson

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d81d3e34776a
https://hg.mozilla.org/mozilla-central/rev/9c6c5a89c5de
https://hg.mozilla.org/mozilla-central/rev/8e40d12c576d

Comment 13

[Florian Zia [:flozia]]

Attachment: Bug 2051359 - Part 1: Add small size variant to ai-website-chip

Original Revision: https://phabricator.services.mozilla.com/D312330

Comment 14

[Florian Zia [:flozia]]

Attachment: Bug 2051359 - Part 2: Support custom child items in smartwindow-panel-list

Original Revision: https://phabricator.services.mozilla.com/D312331

Comment 15

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Prerequisite for bug 2053889 and bug 2057237.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing: no
• Risk associated with taking this patch: low
• Explanation of risk level: Adds a UI component only.
• String changes made/needed?: Yes
• Is Android affected?: yes

Comment 16

[Florian Zia [:flozia]]

Attachment: Bug 2051359 - Part 3: Add citation component for assistant chat messages

Original Revision: https://phabricator.services.mozilla.com/D312332

Comment 17

[Dianna Smith [:diannaS]]

this has string changes, NI l10n team for approval

Comment 18

[Bryan Olsson [:bolsson]]

Since smart window releases only to two locales and translations exist for the strings, its okay to uplift.

Comment 19

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/2d76559d88ae
https://hg.mozilla.org/releases/mozilla-beta/rev/2156f2377a6a
https://github.com/mozilla-firefox/firefox/commit/fa1c54277424
https://hg.mozilla.org/releases/mozilla-beta/rev/99a43018e1c9
https://github.com/mozilla-firefox/firefox/commit/1a5d3bb5e088
https://hg.mozilla.org/releases/mozilla-beta/rev/59406f38e565

Comment 20

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Release 154.0.1 and our latest Beta 155.0b3