2051445 - Search term jumps rightwards in URL bar after you've submitted it

Status: RESOLVED FIXED

(Firefox :: Protections UI, defect, P2)

Description

[Daniel Holbert [:dholbert]]

STR:

1. Type any search query (e.g. test) into your URL bar
2. Hit enter.
3. See what happens to that search query in your URL bar.

ACTUAL RESULTS:
The search query jumps rightwards. (Nothing else in the URL bar moves; just the search query.)

EXPECTED RESULTS:
No such jump.

Regression range:
https://hg-edge.mozilla.org/integration/autoland/pushloghtml?fromchange=3385c294f2337d197ac8573bae60c432cde1deca&tochange=df04a5ae1f2f4ccc25ad030e10cc276243547ab9

--> Regression from the margin added in bug 2012038.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screencast of bug

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screenshot before hitting Enter

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: screenshot after hitting Enter

Comment 4

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 2012038

Comment 5

[Daisuke Akatsuka (:daisuke)]

Thank you very much, Daniel!
Yeah, I confirmed this issue. I will fix it.

Comment 6

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 2051445 - Put the urlbar input gap on the input box instead of preceding components

This bug was caused by #identity-box still getting a margin-inline-end even
though all of its children were hidden and the box was effectively invisible,
because the box itself was not display: none. So, when all of its children
are hidden, set the hidden attribute on #identity-box to make it
display: none.

Comment 7

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:emz, could you have a look please?

For more information, please visit BugBot documentation.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f340ab6fd3da
https://hg.mozilla.org/integration/autoland/rev/02e983e617bf
Put the urlbar input gap on the input box instead of preceding components r=adw,desktop-theme-reviewers,urlbar-reviewers,dao

Comment 9

[rperta]

https://hg.mozilla.org/mozilla-central/rev/02e983e617bf

Comment 10

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:daisuke, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox153 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2026-06-29 Firefox Nightly build on Windows 11.

Verified as fixed on Firefox Nightly 154.0a1 on Windows 11, macOS 15.