2051597 - Bug 2046258 incomplete for Thunderbird

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[John Bieling]

In order for Thunderbird to adjust to Bug 2046258, there needs to be an additional fix in m-c.

Comment 1

[John Bieling]

Attachment: Bug 2051597 - Adapt the MOZ_THUNDERBIRD master-password prompt in nsXREDirProvider for the async nsIPKCS11Token.login(). r=#thunderbird-reviewers,keeler

Bug 2046258 made nsIPKCS11Token.login() asynchronous and updated the
Firefox callers, but missed the caller in the #ifdef MOZ_THUNDERBIRD
block of nsXREDirProvider::DoStartup().

That caller must finish prompting before any windows open (to avoid the
multiple-prompt race, bug 177175), so it cannot simply fire-and-forget
the Promise. Drive the Promise returned by Login() and spin the event
loop until it settles; PK11_Authenticate runs off the main thread, so
the loop stays responsive.

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 2046258

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0dcc26d2a771
https://hg.mozilla.org/integration/autoland/rev/703f4bec304e
Adapt the MOZ_THUNDERBIRD master-password prompt in nsXREDirProvider for the async nsIPKCS11Token.login(). r=keeler,thunderbird-reviewers,edicharry

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/42a764fc9d59
https://hg.mozilla.org/mozilla-central/rev/09345f992eb9
Adapt the MOZ_THUNDERBIRD master-password prompt in nsXREDirProvider for the async nsIPKCS11Token.login(). r=keeler,thunderbird-reviewers,edicharry

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/09345f992eb9

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/703f4bec304e