2051628 - [Intermittent] The sponsored tiles and the Add Shortcut button look like they reload when pinning and unpinning shortcuts

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Carmen Fat [:cfat] - Ecosystem QA]

Attachment: sponsored and add shortcut reloaded.mp4

[Affected versions]:

• Firefox Nightly 154.0a1 (Build ID: 20260629214814)

[Affected Platforms]:

• Windows 11 x64
• macOS 15.7.4
• Ubuntu 24.04 x64

[Prerequisites]:

• Have Firefox Nightly 154 installed on your machine.
• Make sure the following pres are set in about:config:
  -> browser.nova.enabled = true
  -> browser.newtabpage.activity-stream.nova.enabled = true
  -> browser.newtabpage.activity-stream.topSitesGroupedPins = true
• Have Sponsored and non-Sponsored tiles displayed.

[Steps to reproduce]:

1. Open the browser with the profile from the prerequisites.
2. Open a new tab and click the “...” menu of a non-sponsored tile.
3. Click the “Pin” option.
4. Observe the Sponsored tiles and the “Add Shortcut” button.

[Expected result]:

• Nothing happens; pinning/unpinning tiles doesn’t influence the Sponsored tiles UI/behavior.

[Actual result]:

• The Sponsored tiles look like they reload.

[Notes]:

• Attached is a screen recording of the issue.
• I did not reproduce the issue with the browser.newtabpage.activity-stream.topSitesGroupedPins pref set to false.

Comment 1

[Scott [:thecount] Downe]

I wasn't able to test this initially, it only happens when the first pin is pinned, or only 1 pin is unpinned.

This causes the wrapper to toggle between 0 pin and 1+ pin wrappers, which is causing react to remount the whole subtree because it's no longer the same.

The solution is to ensure the subtree doesn't change when going between 0 pin and 1+ pin containers, by making them just 1 container.

Comment 2

[Scott [:thecount] Downe]

Attachment: Bug 2051628 - Newtab fixing mounting react wrapper for shortcuts

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/81e056093c56
https://hg.mozilla.org/integration/autoland/rev/a4fc58048866
Newtab fixing mounting react wrapper for shortcuts r=ini

Comment 4

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/a4fc58048866