2052478 - Audit usage of EARLY_BETA_OR_EARLIER for `dom.event.keypress.key.allow_lone_surrogate`

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, task, P1)

Description

[Hsin-Yi Tsai (she/her) [:hsinyi]]

We need to audit the usage and replace with another macro before August 17, when Nightly 155 merges to Beta.
See bug 2051729 comment 0

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi Masayuki, can you please audit this usage and update it properly? Thank you.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Well, it seems that it's fine to ship the better behavior even though it's not compatible with Chrome.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 2052478 - Ship the better `keypress.charCode` behavior when typing a surrogate pair r=smaug!

The pref was added in bug 1840519, 3 years ago. The motivation of the
new behavior is, String.fromCharCode(event.charCode) won't create
ill-formed UTF-16 string only from the high-surrogate or the
low-surrogate.

Unfortunately, this behavior is incompatible with Chrome, but we don't
get any bug reports from our testers in this 3 years. So, I think
shipping this is enough safe and the new behavior is better from the
Unicode spec point of view.

Note that there must be only a few keyboard layouts which can type
non-BMP characters directly. I tried to test it with creating a
custom keyboard layout (attachment 9341661 [details]). So, originally, this bug
affected only a small number of users.

Comment 4

[Phabricator Automation]

Comment on attachment 9604400 [details]
Bug 2052478 - Ship the better keypress.charCode behavior when typing a surrogate pair r=smaug!

Revision D310450 was moved to bug 1849790. Setting attachment 9604400 [details] to obsolete.

Comment 5

[Phabricator Automation]

Comment on attachment 9604400 [details]
Bug 2052478 - Ship the better keypress.charCode behavior when typing a surrogate pair r=smaug!

Revision D310450 was moved to bug 1849790. Setting attachment 9604400 [details] to obsolete.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

It's removed by shipping the new behavior in bug 1849790.