2052554 - Make global-action (ActionsResult) results serializable for the urlbar actor boundary

Status: RESOLVED FIXED

(Firefox :: Address Bar, task)

Description

[Dão Gottwald [:dao]]

Global-action results (ActionsResult) store their data in private fields exposed through getters, which structuredClone drops when a result crosses the Urlbar JSWindowActor boundary. Give ActionsResult explicit toWire()/fromWire() serialization so it survives the boundary, mirroring UrlbarResult.

No-op on the default direct (in-process) path; prepares the type for the message path.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 2052554 - [IPC Urlbar] Phase 6: Make global-action results wire-safe. r?daleharvey,mbeier

Global-action results (the actions row) carry their per-action data -- key,
l10nId, l10nArgs, icon, dataset, engine -- in ActionsResult objects
held on the result payload. ActionsResult stored that data in private fields
exposed through getters, which a structured clone drops (it copies only own
enumerable data properties), so over the actor message path the actions rendered
blank; only providerName, a public field, survived.

Store the data in plain public fields instead, so the payload stays structured-
cloneable, and freeze the instance to keep it read-only as the getters did.
providerName can no longer be stamped on after construction (the object is
frozen), so each provider passes its own name in; the constructor now requires
providerName and key and throws without them.

The default in-process path is unaffected.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3642578ee505
https://hg.mozilla.org/integration/autoland/rev/ef1449c1b8d9
[IPC Urlbar] Phase 6: Make global-action results wire-safe. r=mbeier,urlbar-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7eba9016c92f
https://hg.mozilla.org/integration/autoland/rev/af778aeb69c9
Revert "Bug 2052554 - [IPC Urlbar] Phase 6: Make global-action results wire-safe. r=mbeier,urlbar-reviewers" for causing xpcshell failures on test_quicksuggest.js.

Comment 4

[Iulian Moraru]

Revert for causing xpcshell failures on test_quicksuggest.js.

• Push with failures

• Failure log

• Backout link

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1be49a3769ee
https://hg.mozilla.org/integration/autoland/rev/8e994b333b6c
[IPC Urlbar] Phase 6: Make global-action results wire-safe. r=mbeier,urlbar-reviewers

Comment 6

[rperta]

https://hg.mozilla.org/mozilla-central/rev/8e994b333b6c