2052555 - Await a dynamic result's pending view update via waitForAutocompleteResultAt

Status: ASSIGNED

(Firefox :: Address Bar, task)

Description

[Dão Gottwald [:dao]]

A dynamic result's view update is applied asynchronously — UrlbarView awaits the provider's getViewUpdate() — so the updated DOM can land after the row is first shown. Tests that assert on the updated DOM can race that update (especially visible when the update round-trips over the urlbar actor message path).

Dispatch a DynamicResultUpdated event once the update is applied, add a UrlbarTestUtils.promiseDynamicResultUpdated helper, and have the affected tests (browser_dynamicResults.js) await it before asserting. Behavior-neutral for product code — the event is only observed by tests.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 2052555 - [IPC Urlbar] Phase 6: Await a dynamic result's pending view update via waitForAutocompleteResultAt. r?mbeier!

A dynamic result's view update is applied asynchronously (the view awaits
getViewUpdate), and on the message path that's an actor round-trip, so the
update can land well after the row is shown. Tests that assert on the updated
DOM raced it and failed only on the wire.

Dispatch a DynamicResultUpdated event once the update is applied, add a
UrlbarTestUtils.promiseDynamicResultUpdated helper, and have the highlighting
subtests await it before asserting.