2052599 - [IPProtection] Onboarding card flow is broken for already authenticated users

Status: VERIFIED FIXED

(Firefox for Android :: Privacy, defect)

Description

[Mike a [:mavduevskiy]]

link to STP

Steps to reproduce

1. Log in into account
2. Wait for the onboarding popup (in the video, I forced it to be always shown, for the ease of testing)
3. Authorize vpn

Expected behavior

VPN turns on

Actual behavior

VPN shows an error and locks in "connecting" state until the next cold start

Device information

• Firefox version:
• Android device model:
• Android OS version:

Any additional information?

Comment 1

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 2050967

Comment 2

[Mike a [:mavduevskiy]]

Attachment: Bug 2052599 - Fix vpn onboarding flow for signed

... in users.

Please enter the commit message for your changes. Lines starting

Comment 3

[Mike a [:mavduevskiy]]

Attachment: Bug 2052599 - Part 2: Add testing coverage

Comment 4

[Phabricator Automation]

Comment on attachment 9604809 [details]
Bug 2052599 - Part 2: Add testing coverage

Revision D310680 was moved to bug 2052966. Setting attachment 9604809 [details] to obsolete.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b7a0a4519481
https://hg.mozilla.org/integration/autoland/rev/46eab8b60339
Fix vpn onboarding flow for signed r=android-reviewers,jonalmeida

Comment 6

[amarc]

https://hg.mozilla.org/mozilla-central/rev/46eab8b60339

Comment 7

[Mike a [:mavduevskiy]]

Attachment: Bug 2052599 - Fix vpn onboarding flow for signed

...in users.

Original Revision: https://phabricator.services.mozilla.com/D310430

Comment 8

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: The patch fixes vpn onboarding flow for already existing users. Without it, a logged in user going through "try vpn" flow will get stuck in "connecting" state until they they restart (cold start) the app.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: The patch is scoped to the VPN feature, and consists in slight adjustments to the vpn state machine.
• String changes made/needed?: no
• Is Android affected?: yes

Comment 9

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/9605de1528e1
https://hg.mozilla.org/releases/mozilla-beta/rev/5a4144ae0b35

Comment 10

[Maria Berlinger [:mberlinger], Fxa/Subplat]

Attachment: Recording_20260713_135839 1(1).mp4

Hi,
We verified this bug on Firefox 153.0b11 and the latest Nightly build 154.0a1 (Build #2016172351). Following the steps previously provided by Mike, we are no longer able to reproduce the issue.
 
However, we noticed that the error is displayed when performing the following steps:

1. Set the device locale to US.
2. Clear the Google Play Store cache.
3. Install the Beta/Nightly build.
4. Sign in to Sync using a newly created account.
5. Change the device date to 7 days in the future.
6. Force close (swipe away) Firefox.
7. Reopen Firefox and go through the onboarding flow.
   Based on our observations, the issue reproduces intermittently under these conditions.

Would you recommend reopening this issue, or should we file a new bug to track this intermittent behavior?

Thanks.

Comment 11

[Mike a [:mavduevskiy]]

hi,
thank you for verifying that the initial patch works!

I spent quite a bit of time debugging, and you found a separate issue - a race condition. When we move the device clock, we force the fxa tokens to expire, and that forces fxa to reauth (on a good connection, it takes ~4, 5 seconds to finalize and report ready). If by that time the user has initiated the vpn auth flow (onboarding or (!) through regular vpn settings screen), we fail to initialize vpn machinery properly, and we end up in broken state. I will create a separate bug for that.

Comment 12

[Mike a [:mavduevskiy]]

opsy, the intention was to close it and work on the new issue separately.

the follow up
https://bugzilla.mozilla.org/show_bug.cgi?id=2054812