2052637 - Pressing Page Up or Page Down keys does nothing when the textarea is not overflowing and the page is scrollable

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect)

Description

[6k64x4ma]

Attachment: testcase.html

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:153.0) Gecko/20100101 Firefox/153.0

Steps to reproduce:

Load the attached file and press the Page Down key.

Actual results:

The caret does not move to the last line.
Page Up, Shift + Page Up, and Shift + Page Down also do not work.

Expected results:

The caret should move to the last line.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=02376ed8674012d2bd575682466cc9177039adb9&tochange=a77a08b9be8a059936afa68f259adb86823bb75f

Comment 1

[BugBot [:suhaib / :marco]]

:emilio, since you are the author of the regressor, bug 2031757, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2052637 - Fix nsFrameSelection::GetPageToFrameSelect. r=masayuki,#dom-core

In this test-case, rootFrameToSelect is the inner editor's frame, but
contentToSelect is the textarea, which is an ancestor.

So we go from <textarea> all the way to the root frame finding
scrollable frames which is not the intended behavior. Instead, we check
nsLayoutUtils::IsProperAncestorFrame to make sure that we walk
correctly.

Comment 3

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 2031757

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bca004a62f9c
https://hg.mozilla.org/integration/autoland/rev/f3fcb929f314
Fix nsFrameSelection::GetPageToFrameSelect. r=layout-reviewers,dshin

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/61093 for changes under testing/web-platform/tests

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c86fcb7f2272
https://hg.mozilla.org/integration/autoland/rev/843b141a4b58
Revert "Bug 2052637 - Fix nsFrameSelection::GetPageToFrameSelect. r=layout-reviewers,dshin" for causing failures at textarea-pagedown-selection.html.

Comment 7

[Atila Butkovits]

Backed out for causing failures at textarea-pagedown-selection.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/843b141a4b58

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=cgY0VQ7-QtKnp7J7Uxxobw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=f3fcb929f3144c59e89b6e26348cc8117dd8a03f

Failure log: https://treeherder.mozilla.org/logviewer?job_id=577049426&repo=autoland&task=cgY0VQ7-QtKnp7J7Uxxobw.0&lineNumber=17354

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/23778bbea20b
https://hg.mozilla.org/integration/autoland/rev/092bceb6df5a
Fix nsFrameSelection::GetPageToFrameSelect. r=layout-reviewers,dshin

Comment 11

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/092bceb6df5a

Comment 12

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox153 to wontfix.

For more information, please visit BugBot documentation.

Comment 13

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Trivial-ish regression fix.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: comment 0
• Risk associated with taking this patch: low
• Explanation of risk level: Targeted codepath.
• String changes made/needed?: none
• Is Android affected?: unknown

Comment 14

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2052637 - Fix nsFrameSelection::GetPageToFrameSelect.

In this test-case, rootFrameToSelect is the inner editor's frame, but
contentToSelect is the textarea, which is an ancestor.

So we go from <textarea> all the way to the root frame finding
scrollable frames which is not the intended behavior. Instead, we check
nsLayoutUtils::IsProperAncestorFrame to make sure that we walk
correctly.

Original Revision: https://phabricator.services.mozilla.com/D310594

Comment 15

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/3e048105f17f
https://hg.mozilla.org/releases/mozilla-beta/rev/68fe31ab8b6b

Comment 16

[Monica Chiorean]

I was able to reproduce the issue on Win11x64 using FF build 152.0.5.
Verified as fixed on Win11x64 using FF build 154.0a1. Waiting for next beta to verify it.

Comment 17

[Monica Chiorean]

Verified as fixed on Win11x64 using FF build 153.0b11.