2052753 - Update libcubeb and cubeb-pulse-rs to latest upstream revisions

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, task)

Description

[Matthew Gregan [:kinetik]]

Vendor the latest upstream revisions of libcubeb and cubeb-pulse-rs.

• libcubeb: cdb54bbf -> a665efba31740bd477cf2001a5cb289a63e85336
• cubeb-pulse-rs: a3770b75 -> 88194f91c8778fa608a19af7b91306094525595d

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: Bug 2052753 - Update libcubeb to 6d5e5e6. r?#cubeb-reviewers

Comment 2

[Matthew Gregan [:kinetik]]

Attachment: Bug 2052753 - Update cubeb-pulse-rs to 88194f9. r?#cubeb-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b68e322065a8
https://hg.mozilla.org/integration/autoland/rev/244a84acda4b
Update libcubeb to 6d5e5e6. r=cubeb-reviewers,padenot
https://github.com/mozilla-firefox/firefox/commit/25f378e8f4ee
https://hg.mozilla.org/integration/autoland/rev/aebbfa82dea9
Update cubeb-pulse-rs to 88194f9. r=cubeb-reviewers,padenot

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f2eeeebd7ba9
https://hg.mozilla.org/integration/autoland/rev/652300ab8a98
Revert "Bug 2052753 - Update cubeb-pulse-rs to 88194f9. r=cubeb-reviewers,padenot" for causing failures at Cargo.lock.

Comment 5

[Atila Butkovits]

Backed out for causing failures at Cargo.lock

Backout link: https://hg.mozilla.org/integration/autoland/rev/652300ab8a98

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=aebbfa82dea915a7428a03e44a07c7ae53d4f70c&selectedTaskRun=NSBvRF1-QKel6PEPqjA-XQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=577150679&repo=autoland&task=NSBvRF1-QKel6PEPqjA-XQ.0&lineNumber=127

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6a0e65596b1f
https://hg.mozilla.org/integration/autoland/rev/cfe40e2a7ce3
Update libcubeb to 6d5e5e6. r=cubeb-reviewers,padenot
https://github.com/mozilla-firefox/firefox/commit/00ecae69541a
https://hg.mozilla.org/integration/autoland/rev/574d41f9708e
Update cubeb-pulse-rs to 88194f9. r=cubeb-reviewers,padenot

Comment 7

[amarc]

https://hg.mozilla.org/mozilla-central/rev/cfe40e2a7ce3
https://hg.mozilla.org/mozilla-central/rev/574d41f9708e

Comment 8

[Pascal Chevrel (relman team) -> :pascalc]

kinetik, could you request uplift to beta/esr115/esr140? Thanks

Comment 9

[Matthew Gregan [:kinetik]]

Attachment: Bug 2052753 - Backport upstream cubeb fix for the ALSA drain contract.

Upstream cubeb commit a665efba31740bd477cf2001a5cb289a63e85336 ("alsa: fix
drain contract"), carried as a local patch rather than bumping the vendored
libcubeb revision.

Original Revision: https://phabricator.services.mozilla.com/D310551

Comment 10

[Matthew Gregan [:kinetik]]

Attachment: Bug 2052753 - Update cubeb-pulse-rs to 5eb4d5b to reject start() on a draining stream.

Backport of upstream cubeb-pulse-rs commit
88194f91c8778fa608a19af7b91306094525595d, carried on the
mozilla/cubeb-pulse-rs beta branch.

Original Revision: https://phabricator.services.mozilla.com/D310552

Comment 11

[Matthew Gregan [:kinetik]]

Attachment: Bug 2052753 - Update cubeb-pulse-rs to b46defa to reject start() on a draining stream.

Backport of upstream cubeb-pulse-rs commit
88194f91c8778fa608a19af7b91306094525595d, carried on the
mozilla/cubeb-pulse-rs esr140 branch.

The backport adapts the error construction to the cubeb-backend version
vendored on this branch (Error::error() rather than Error::Error).

Original Revision: https://phabricator.services.mozilla.com/D310552

Comment 12

[Matthew Gregan [:kinetik]]

Attachment: Bug 2052753 - Update cubeb-pulse-rs to 405f174 to reject start() on a draining stream.

Backport of upstream cubeb-pulse-rs commit
88194f91c8778fa608a19af7b91306094525595d, carried on the
mozilla/cubeb-pulse-rs esr115 branch.

The backport adapts the error construction to the cubeb-backend version
vendored on this branch (Error::error() rather than Error::Error).

Original Revision: https://phabricator.services.mozilla.com/D310552

Comment 13

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Security fixes for PulseAudio and ALSA audio backends.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Fixes are relatively simple and only affect behaviour on specific error paths, no behaviour change during normal operation.
• String changes made/needed?: None.
• Is Android affected?: no

Comment 14

[Phabricator Automation]

firefox-esr140 Uplift Approval Request

• User impact if declined/Reason for urgency: Security fix for PulseAudio audio backend. Potential content->parent sandbox escape.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Fix is relatively simple and only affect behaviour on specific error paths, no behaviour change during normal operation.
• String changes made/needed?: None.
• Is Android affected?: no

Comment 15

[Phabricator Automation]

firefox-esr115 Uplift Approval Request

• User impact if declined/Reason for urgency: Security fix for PulseAudio audio backend. Potential content->parent sandbox escape.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Fix is relatively simple and only affect behaviour on specific error paths, no behaviour change during normal operation.
• String changes made/needed?: None.
• Is Android affected?: no

Comment 16

[Matthew Gregan [:kinetik]]

(In reply to Pascal Chevrel (relman team) -> :pascalc from comment #8)

kinetik, could you request uplift to beta/esr115/esr140? Thanks

All done, thanks.

Comment 17

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/666183e68304
https://hg.mozilla.org/releases/mozilla-beta/rev/af72d33919ec
https://github.com/mozilla-firefox/firefox/commit/f72e3d576b4e
https://hg.mozilla.org/releases/mozilla-beta/rev/582de8254528

Comment 18

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr140/rev/13e64b4127aa

Comment 19

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/1ef5c73b865c