2052798 - Make asserts in VerifyClientPrincipalInfosMatch more granular

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, task)

Description

[Vincent Hilla [:vhilla]]

(In reply to Andrew Sutherland [:asuth] (he/him) from bug 2021375 comment #2)

I believe the problem I've identified in bug 2013379 and have a fix coming for imminently should ideally address this.

I'd like to verify that bug 2021375 is indeed due to bug 2013379. To do this, I think we should make the asserts in VerifyClientPrincipalInfosMatch more granular so we know which of leftContent.attrs() == rightContent.attrs() && leftContent.originNoSuffix() == rightContent.originNoSuffix() is failing, and whether it's the foreign bit on the partition key.

Comment 1

[Vincent Hilla [:vhilla]]

Attachment: Bug 2052798 - Make asserts in VerifyClientPrincipalInfosMatch more granular. r=#dom-core

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e4b843d03a44
https://hg.mozilla.org/integration/autoland/rev/89954b5860e9
Make asserts in VerifyClientPrincipalInfosMatch more granular. r=dom-core-reviewers,smaug

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/89954b5860e9

Comment 4

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: This is giving us more information about an existing crash (bug 2021375). Due to the low crash volume on Nightly, uplifting will give us useful information sooner.
• Code covered by automated testing?: unknown
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing: Nothing, this is a task not a fix.
• Risk associated with taking this patch: low
• Explanation of risk level: Patch is splitting an assert so we know better which part is failing.
• String changes made/needed?: No
• Is Android affected?: yes

Comment 5

[Vincent Hilla [:vhilla]]

Attachment: Bug 2052798 - Make asserts in VerifyClientPrincipalInfosMatch more granular.

Original Revision: https://phabricator.services.mozilla.com/D310579

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr153/rev/630ef9ffa27d