2052861 - [wllama] wllama fails to initialize without blob:system support

Status: RESOLVED FIXED

(Core :: Machine Learning: On Device, defect, P2)

Description

[Valentin Pollet]

Recent work landed that changed blob:system URIs to an arbitrary null principal broke wllama, on initialization we now get:

Error: Worker constructor: Failed to load worker script at "...".

Comment 1

[Valentin Pollet]

I investigated a bit and wllama is indeed broken on Nightly, we can see the error in Link Preview generate showing up in telemetry. In this query we can see that the error I reported is not seen before June 28th, and 9 of them after that date.

We have 0 testing exercising a real wllama wasm blob and and actual inference, the regression is not catchable in CI

Comment 2

[Valentin Pollet]

Attachment: Bug 2052861 - Added e2e tests running wllama and onnx wasm r=nordzilla

Comment 3

[Valentin Pollet]

Attachment: Bug 2052861 - Gate Link Preview key points on llama.cpp support r=gregtatum

Link Preview key-points are now skipped for users running non-AVX2 hardware.
Key-points users now only run native llama.cpp.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/19821d1b10d2
https://hg.mozilla.org/integration/autoland/rev/c6d24cf8eddf
Gate Link Preview key points on llama.cpp support r=gregtatum,flozia

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/dde0b0151820
https://hg.mozilla.org/integration/autoland/rev/4a0d04fa83ac
Revert "Bug 2052861 - Gate Link Preview key points on llama.cpp support r=gregtatum,flozia" for causing bc failures @ browser_link_preview.js

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_link_preview.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/4a0d04fa83ac3ecdcdf54028904af0a5e906a8ed

Push with failures

Failures log ->TEST-UNEXPECTED-FAIL | browser/components/genai/tests/browser/browser_link_preview.js | test_skip_generate_if_non_eng - generateTextAI for allowed language - Got +0, expected 1

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a629590da638
https://hg.mozilla.org/integration/autoland/rev/9e33d25a5714
Gate Link Preview key points on llama.cpp support r=gregtatum,flozia

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/9e33d25a5714

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/9e33d25a5714

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/9e33d25a5714

Comment 11

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/9e33d25a5714

Comment 12

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:vpollet, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox154 to wontfix.

For more information, please visit BugBot documentation.

Comment 13

[Valentin Pollet]

Attachment: Bug 2052861 - Gate Link Preview key points on llama.cpp support

Link Preview key-points are now skipped for users running non-AVX2 hardware.
Key-points users now only run native llama.cpp.

Original Revision: https://phabricator.services.mozilla.com/D311367

Comment 14

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/d932c330b2e8
https://hg.mozilla.org/releases/mozilla-beta/rev/e504619936c5