2052899 - Remove uses of EARLY_BETA_OR_EARLIER from js/ directory.

Status: NEW

(Core :: JavaScript Engine, task, P2)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

See https://groups.google.com/a/mozilla.org/g/firefox-dev/c/4TV18A6Pwx0/m/ig07daQOAgAJ?utm_medium=email&utm_source=footer for reasoning.

To prepare, we ask that teams:

1. Audit your code’s use of the EARLY_BETA_OR_EARLIER macro.
2. Replace your code’s use of EARLY_BETA_OR_EARLIER with:
   • NIGHTLY_BUILD, if the functionality is ready for QA and user testing but not release
   • or (NIGHTLY_BUILD || MOZ_DEV_EDITION), if the functionality needs more user testing beyond Nightly but isn’t ready for release. Warning: having different functionality in DevEdition and Beta will complicate testing. You should consider when (or if) you will eventually ship this functionality.
   • or enable by default, if the functionality is ready to ride the trains to Release.

Comment 1

[Jon Coppeard (:jonco)]

The deadline for this is coming up on August 17, when Nightly 155 merges to Beta.

Current uses in our code:

https://searchfox.org/firefox-main/search?q=EARLY_BETA_OR_EARLIER&path=js%2F&case=true&regexp=false

js/src/builtin/TestingFunctions.cpp 296	#ifdef EARLY_BETA_OR_EARLIER
js/src/frontend/BytecodeCompiler.cpp 1589	#if defined(EARLY_BETA_OR_EARLIER) || defined(DEBUG)
js/src/frontend/ParseNode.h 700	#if defined(EARLY_BETA_OR_EARLIER)
js/src/gc/BufferAllocator.cpp 281	#ifndef EARLY_BETA_OR_EARLIER
js/src/jit/BacktrackingAllocator.h 19	// Gives better traces in Nightly/debug builds (could be EARLY_BETA_OR_EARLIER)