Closed Bug 2052956 Opened 4 months ago Closed 4 months ago

Selected state isn't visually indicated in the new sidebar Open Tabs panel for pinned tabs

Categories

(Firefox :: Sidebar, defect)

defect

Tracking

()

RESOLVED FIXED
154 Branch
Tracking Status
firefox154 --- fixed

People

(Reporter: kcochrane, Assigned: dr.seed.lu, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-sidebar][outreachy-sidebar-2026])

Attachments

(1 external file)

In the new sidebar Open Tabs panel, we've added a visual indicator of selected tabs similar to how to show this in the tab strip. It looks like this doesn't apply when a pinned tabs is selected however.

The severity field is not set for this bug.
:jsudiaman, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(jsudiaman)

Pinned tabs in the open tabs panel render as icon buttons, so they never
showed the selected-tab indicator that the regular rows already have. The
selected pinned tab now gets the same indicator, and it moves as you switch
tabs.

The panel only listened for TabChange, which does not fire on tab selection,
so it now also listens for TabRecencyChange to re-render the pinned icons.
The selected button is styled with the same border the regular rows use,
applied to the button's inner part since that is what paints the background.

Assignee: nobody → dr.seed.lu
Status: NEW → ASSIGNED
Severity: -- → S4
Flags: needinfo?(jsudiaman)
Pushed by kcochrane@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/4c54971be16b https://hg.mozilla.org/integration/autoland/rev/6d37855fef3c Show the selected state on pinned tabs in the open tabs sidebar panel r=kcochrane,nsharpley,desktop-theme-reviewers
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
QA Whiteboard: [qa-triage-done-c155/b154]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: