2053068 - Low contrast for inactive tabs in horizontal and vertical tabs

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P2)

Description

[Sarah Clements [:sclements] | PTO until Oct 12th]

User filed a bug during foxfood about low contrast with inactive tabs in inactive windows in light and dark themes; the contrast is different with nova disabled. It makes the tab text harder to read.

Looks like bookmark text and urlbar text has better contrast so we should look into using that for the tab text.

Comment 1

[James Teh [:Jamie]]

Access s2 for insufficient contrast.

Comment 2

[BugBot [:suhaib / :marco]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:nsharpley, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 3

[Nikki Sharpley (:nikkis) (she/her)]

Looks like this is coming from: https://searchfox.org/firefox-main/rev/d83a08d81de20f3b72db70f531fad19090e1db4b/toolkit/themes/shared/design-system/dist/tokens-shared.css#1100

Mark, I think this got pulled in from Figma. Do we need to update the Figma to fix this so the text color can remain as --toolbox-text-color?

Comment 4

[Mark Striemer [:mstriemer]]

Attachment: Bug 2053068 - Don't dim titlebar text when inactive r?#desktop-theme-reviewers!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e178d7d42c58
https://hg.mozilla.org/integration/autoland/rev/4adc03b1cddf
Don't dim titlebar text when inactive r=Dre,emilio,desktop-theme-reviewers,hjones
https://github.com/mozilla-firefox/firefox/commit/656c2befa4aa
https://hg.mozilla.org/integration/autoland/rev/8d5a541cdb9d
2053746, 2057241: apply code formatting via Lando

Comment 6

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/4adc03b1cddf
https://hg.mozilla.org/mozilla-central/rev/8d5a541cdb9d